New issue
Advanced search Search tips

Issue 765472 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Milo/LUCI: Annotation proto contains a really dumb encoding for property maps

Project Member Reported by iannucci@chromium.org, Sep 14 2017

Issue description

See https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/common/proto/milo/annotations.proto?q=milo+annotation&sq=package:chromium&l=133 ("Property").

In particular this should be the 'well known type' proto.Struct, which is designed to embed JSON inside proto, and has a much more natural API from inside Go/Python.
 

Comment 1 by no...@chromium.org, Sep 15 2017

If we start making breaking changes to annotation proto, I'd revisit the whole thing, because it is based on / designed around concepts we don't want remove (annotations). If would be great to design a nice clean proto message for builds.

Comment 2 by s...@google.com, Sep 23 2017

Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 24

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
I believe we won't make any changes to this in favor of going forward with buildbucket v2.

Sign in to add a comment