New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765462 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
(OOO slow)
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on: View detail
issue 596533
issue 650548
issue 683220
issue 690041
issue 761946
issue 765796
issue 776541
issue 794623
issue 810891
issue 832539
issue 837998
issue 540820
issue 662104
issue 765403
issue 778693
issue 800334
issue 818515
issue 828780
issue 837996
issue 837997



Sign in to add a comment

[TTS] Update Contextual Search tests - tracking bug

Project Member Reported by donnd@google.com, Sep 14 2017

Issue description

We should investigate recent flakiness in our tests.  Several have gotten disabled recently.  Some only fail on Marshmallow 64 bit -- I wonder why.  (See issue 596533 which does a conditional disable) 
 

Comment 1 by donnd@google.com, Sep 15 2017

Blockedon: 765403

Comment 2 by donnd@google.com, Sep 15 2017

Blockedon: 765796

Comment 3 by donnd@google.com, Oct 19 2017

Blockedon: 776541

Comment 4 by donnd@google.com, Oct 27 2017

Blockedon: 778693
testTriggeringContextualSearchHidesFindInPageOverlay is flaky, and super-flaky on Nougat.

testSecondTapWithSmartSelection is flaky (issue 778693)

Comment 5 by donnd@google.com, Oct 27 2017

Some possible reasons for flakiness:
A) We use pollInstrumentationThread instead of pollUiThread (the latter is recommended by CriteriaHelper).
B) We don't check that simulated taps are actually recognized (though the underlying function returns a success boolean).
C) Issue 778540 where cancelling animation (fix pending).  I saw some tests get stuck waiting for the panel to peek but it was already peeked.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42fb77482d7b6d3b3c19a5c09a56416a42c71764

commit 42fb77482d7b6d3b3c19a5c09a56416a42c71764
Author: Donn Denman <donnd@google.com>
Date: Mon Oct 30 19:37:53 2017

[TTS] Fix flaky test hiding the FindInPageOverlay.

The testTriggeringContextualSearchHidesFindInPageOverlay has been
very flaky recently, and it looks like the problem is due to clicks
in the content not triggering Contextual Search.  There's probably
a race condition between scrolling to put the word to click into
view and scrolling for the Find target.  The fix is to not type
any Find target to avoid the scroll.

BUG=765462

Change-Id: I007f7fa986e2528d7b7f9a4829be08c566572433
Reviewed-on: https://chromium-review.googlesource.com/742147
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512581}
[modify] https://crrev.com/42fb77482d7b6d3b3c19a5c09a56416a42c71764/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

Comment 7 by donnd@google.com, Dec 13 2017

Blockedon: 794623
Summary: [TTS] Update Contextual Search tests - tracking bug (was: [TTS] Investigate flaky tests)
We should do a general update on various tests for CS including flakes.

Comment 8 by donnd@google.com, Feb 9 2018

Blockedon: 810891

Comment 9 by donnd@google.com, Feb 12 2018

Blockedon: 683220

Comment 10 by donnd@google.com, Feb 13 2018

Blockedon: 650548

Comment 11 by donnd@google.com, Feb 13 2018

Blockedon: 690041

Comment 12 by donnd@google.com, Feb 14 2018

Blockedon: 662104

Comment 13 by donnd@google.com, Mar 4 2018

Blockedon: 818515

Comment 14 by donnd@google.com, Mar 5 2018

Blockedon: 800334

Comment 15 by donnd@google.com, Apr 4 2018

Blockedon: 828780

Comment 16 by donnd@google.com, Apr 16 2018

Blockedon: 832539

Comment 17 by donnd@google.com, Apr 29 2018

Blockedon: 837996

Comment 18 by donnd@google.com, Apr 29 2018

Blockedon: 837997

Comment 19 by donnd@google.com, Apr 29 2018

Blockedon: 837998

Sign in to add a comment