New issue
Advanced search Search tips

Issue 765447 link

Starred by 1 user
Status: Fixed
Owner:
benjhayden@chromium.org
Closed: Oct 2017
Cc:
benjhayden@chromium.org
sullivan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 489954



Sign in to add a comment

FrameViewer page looks broken.

Project Member Reported by vmp...@chromium.org, Sep 14 2017 
Recently frameviewer looks broken. I've attached a screenshot..

It seems that the list on the left isn't styled correctly. I've bisected this to 
crrev.com/0ebd56da

To reproduce, open about:tracing, select frameviewer, record a few seconds of the trace. Then finish and click on the bottom row green circle (visible in screenshots).

broken and fixed screenshots attached.

I'm not really sure if trace viewer should be using different styles here or the patch did something bad (since it seems to just disable a feature). Assigning to the patch author as the starting point.
broken.jpg
106 KB View Download
fixed.jpg
100 KB View Download

Comment 1 by benjhayden@chromium.org, Sep 14 2017 

Thanks for finding this!

We've been ignoring the deprecation warnings about /deep/: https://github.com/catapult-project/catapult/issues/1691

I can fix trace viewer, unless you'd rather make the changes, in which case I can review them.

Comment 2 by hayato@chromium.org, Sep 15 2017

Blocking: 489954
Labels: M-63
Owner: benjhayden@chromium.org
benjhayden@

That should be fixed since we are removing /deep/ at M63. See  http://crbug.com/489954  for details.

Comment 3 by benjhayden@chromium.org, Sep 15 2017 

It looks like 63 will branch on Oct 12, so I'll try to have this done by Oct 1.
I'll coordinate the catapult changes in the catapult bug linked in #c1.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7f8d040aa94c604377db08c074e4fee947f2834c

commit 7f8d040aa94c604377db08c074e4fee947f2834c
Author: benshayden <benjhayden@chromium.org>
Date: Mon Oct 02 20:52:11 2017

Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules into
proper Polymer dom-modules: https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

ListAndAssociatedView appears entirely unused, so it is removed.

http://www/~benjhayden/3017523002.html

https://github.com/catapult-project/catapult/issues/1691
Bug:  chromium:765447 

Change-Id: I505ccaf708dd7f37af129a8e4657f9a5d812b3f2
Reviewed-on: https://chromium-review.googlesource.com/689742
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>

[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/chart_base_2d_brushable_x.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/display_item_debugger.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/base/list_and_associated_view.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/picture_view.css
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/chart_base.html
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/base/tool_button.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/layer_tree_host_impl_view.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/base/list_and_associated_view.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/quad_stack_view.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/picture_view.html
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/base/list_view.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/base/list_and_associated_view_test.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/dom_helpers.html
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_view.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/display_item_list_view.css
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/layer_view.css
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/bar_chart.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/display_item_list_view.html
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/layer_picker.css
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/trace_viewer.gypi
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/layer_tree_host_impl_view.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/chart_base_2d.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/layer_view.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/picture_debugger.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/layer_picker.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
[delete] https://crrev.com/31cacbe5d6d2d4d9cdf1cc6b4c793b62add3c5d0/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.css
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/base/list_view.html
[modify] https://crrev.com/7f8d040aa94c604377db08c074e4fee947f2834c/tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_view.html

Comment 5 by dtu@chromium.org, Oct 2 2017

Cc: -dtu@chromium.org

Comment 6 by benjhayden@chromium.org, Oct 2 2017

Status: Fixed (was: Assigned)
Fixed, assuming the change sticks.
►

Sign in to add a comment