Add histograms to track Network event for connection migration |
||
Issue descriptionTo analyze and understand connection migration impact, we need to collect data on how many users are affected by some particular network events: - NetworkConnected - NetworkMadeDefault - NetworkDisconnected - NetworkSoonToDisconnect. Those are potential triggers for connection migration. Furthermore, we might also want to collect data on how many users are encountering write error issues after triggering potential "connection migration" that is actually not happening.
,
Sep 14 2017
Would it make sense to include write errors (and read errors, for that matter) in this list? Or maybe we already have these?
,
Sep 14 2017
We have Net.QuicSession.ReadError and Net.QuicSession.WriteError tracking those events with net error code. That's more generic. I am planning add code to collect those write/read errors that happen during "migration signals". In particular, those histograms will help answer "how many write/read errors could be potentially reduced if we did connection migration correctly when receiving migration signals". For example, write error on a network interface that is no longer connected or that is marked as soon to disconnect; write error on a network interface that is newly connected and some other similar cases.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4737c694f800dd270f4bdb4b2be4c0967b4d347 commit b4737c694f800dd270f4bdb4b2be4c0967b4d347 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Thu Sep 28 00:49:31 2017 Add histogram to track network-related platform notifications received by QUIC users. Those notifications are: - NetworkConnected - NetworkMadeDefault - NetworkDisconnected - NetworkSoonToDisconnect - IpAddressChanged Bug: 765436 Change-Id: I6205540d9dbbff63010a40ef06febfede2257bef Reviewed-on: https://chromium-review.googlesource.com/687878 Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#504835} [modify] https://crrev.com/b4737c694f800dd270f4bdb4b2be4c0967b4d347/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/b4737c694f800dd270f4bdb4b2be4c0967b4d347/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/b4737c694f800dd270f4bdb4b2be4c0967b4d347/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b4737c694f800dd270f4bdb4b2be4c0967b4d347/tools/metrics/histograms/histograms.xml
,
May 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by zhongyi@chromium.org
, Sep 14 2017