New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765395 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move the proxy resolver Mojo files from net/ to content/

Project Member Reported by jcivelli@chromium.org, Sep 14 2017

Issue description

In preparation of the servicification of ProxyResolver, we should move the related mojo files from net/ to content/.

This is to prevent introducing a dependency to the service manager in net/.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c14aadbf4796703211ed413bc21d8923bc0e6df

commit 1c14aadbf4796703211ed413bc21d8923bc0e6df
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Oct 03 17:08:26 2017

Extracting proxy resolver Mojo files from net/ to their own service.

In preparation of making proxy resolver a Mojo service, moving the
related Mojo files from net/ to the new services/proxy_resolver
directory.

Also some minor clean-ups:
- proxy_resolver_service.mojom renamed to proxy_resolver.mojom
- changing the namespace in proxy_resolver_service.mojom from
  net::interfaces to proxy_resolver::mojom
- replaced base::ThreadChecker with base::SequenceChecker in
  proxy_resolver_factory_mojo.cc to appease the gn warning.

Bug:  765395 
Tbr: sky
Change-Id: Ie133e1edfe73afa54608503030fbe85a41f4f6cd
Reviewed-on: https://chromium-review.googlesource.com/667406
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506081}
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/BUILD.gn
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/chrome_content_utility_manifest_overlay.json
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/io_thread.cc
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/io_thread.h
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/net/DEPS
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/net/chrome_mojo_proxy_resolver_factory.cc
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/net/chrome_mojo_proxy_resolver_factory.h
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/utility/BUILD.gn
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/utility/DEPS
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/network/BUILD.gn
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/network/DEPS
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/public/network/BUILD.gn
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/public/network/DEPS
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/public/network/url_request_context_builder_mojo.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/public/network/url_request_context_builder_mojo.h
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/public/test/DEPS
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/public/test/url_request_context_builder_mojo_unittest.cc
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/content/test/BUILD.gn
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/net/BUILD.gn
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/net/features.gni
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/net/interfaces/BUILD.gn
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/interfaces/proxy_resolver.typemap
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/net/interfaces/typemaps.gni
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/mojo_proxy_resolver_factory_impl.h
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/mojo_proxy_resolver_impl.h
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/mojo_proxy_struct_traits.cc
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/mojo_proxy_struct_traits.h
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/proxy_resolver_factory_mojo.h
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/proxy_service_mojo.cc
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/proxy/test_mojo_proxy_resolver_factory.h
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/url_request/url_request_context_builder_mojo.cc
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/url_request/url_request_context_builder_mojo.h
[delete] https://crrev.com/0ec5859e81c4f7e8620483f800f055cc254e41ec/net/url_request/url_request_context_builder_mojo_unittest.cc
[modify] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/BUILD.gn
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/BUILD.gn
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/DEPS
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/OWNERS
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/mojo_proxy_resolver_factory_impl_unittest.cc
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/mojo_proxy_resolver_impl.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/mojo_proxy_resolver_impl.h
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/mojo_proxy_resolver_impl_unittest.cc
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/proxy_resolver_factory_mojo.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/proxy_resolver_factory_mojo.h
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/proxy_resolver_factory_mojo_unittest.cc
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/proxy_service_mojo_unittest.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/BUILD.gn
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/DEPS
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/OWNERS
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/mojo_proxy_resolver_factory.h
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/mojo_proxy_resolver_factory_impl.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/mojo_proxy_resolver_factory_impl.h
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/proxy_resolver.typemap
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/proxy_resolver_struct_traits.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/proxy_resolver_struct_traits.h
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/proxy_service_mojo.cc
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/proxy_service_mojo.h
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/test_mojo_proxy_resolver_factory.cc
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/test_mojo_proxy_resolver_factory.h
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/cpp/typemaps.gni
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/interfaces/BUILD.gn
[add] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/interfaces/OWNERS
[rename] https://crrev.com/1c14aadbf4796703211ed413bc21d8923bc0e6df/services/proxy_resolver/public/interfaces/proxy_resolver.mojom

Status: Fixed (was: Untriaged)

Sign in to add a comment