New issue
Advanced search Search tips

Issue 765389 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature

Blocking:
issue 767116
issue 589943



Sign in to add a comment

Update visuals of downloads badging on app icon

Project Member Reported by bettes@chromium.org, Sep 14 2017

Issue description

The visuals are out-of-date for app icon badging. If someone can inform UX on what's required to make this update, please let us know. 
 
Screen Shot 2017-09-14 at 1.51.20 PM.png
60.9 KB View Download

Comment 1 by shrike@chromium.org, Sep 15 2017

Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
[mac bug triage] -> sdy@ (who's working on MD downloads)

Comment 2 by sdy@chromium.org, Sep 18 2017

Owner: bettes@chromium.org
bettes@: As mentioned in the doc, this is possible. The drawing is done in code, so specs/mockups/gifs should be enough to change it. Feel free to ping me to discuss and then reassign.

Comment 3 by sdy@chromium.org, Sep 18 2017

Labels: M-63

Comment 4 by bettes@chromium.org, Sep 20 2017

Blockedon: 767116

Comment 5 by bettes@chromium.org, Sep 23 2017

Owner: sdy@chromium.org
Changelist: 
 - new diameter
 - new colors
 - new typography
 - new progress indicator
 - new drop shadow spec

Source file: 
https://drive.google.com/open?id=0BxMIIGI80eU-Y3NJR0FleWZBZ2M

Preview: 
https://drive.google.com/corp/drive/u/0/folders/0BxMIIGI80eU-TVI4a2MxNml2ajQ


P - Download-Badge.png
654 KB View Download
S - Download-Badge.png
83.6 KB View Download

Comment 6 by sdy@chromium.org, Oct 6 2017

Blocking: 589943

Comment 7 by sdy@chromium.org, Oct 6 2017

Blockedon: -767116

Comment 8 by sdy@chromium.org, Oct 6 2017

Blocking: 767116

Comment 9 by sdy@chromium.org, Oct 6 2017

Labels: -M-63 M-64

Comment 10 by sdy@chromium.org, Nov 4 2017

Status: Started (was: Assigned)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/754581

Comment 11 by sdy@chromium.org, Nov 4 2017

How does this look?
Screen Shot 2017-11-04 at 6.11.25 PM.png
75.1 KB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13459ae682362d14282207f9cc941870b3760450

commit 13459ae682362d14282207f9cc941870b3760450
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Nov 13 21:04:15 2017

New appearance for the Dock tile download progress indicator.

Not bothering to put it behind the MD downloads flag because this design
change works well on its own.

Bug:  765389 
Change-Id: I447cbe35dffaef6790d7ae67ea33d1a121b10b39
Reviewed-on: https://chromium-review.googlesource.com/754581
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516043}
[modify] https://crrev.com/13459ae682362d14282207f9cc941870b3760450/chrome/browser/ui/cocoa/dock_icon.mm

c11 LGTM
Labels: TE-Verified-M64 TE-Verified-64.0.3269.3
Tested this issue on Mac 10.12.6 using chrome#64.0.3269.3 as per C#5 & C#12.

Observed new appearance for the chrome doc tile download progress indicator.Now chrome icon progress indicator looks same as S-Download-badge.png in C#5 while downloading any file to local machine.

Tested by downloading Mp4 files and observed new appearance of chrome badge app icon as intended.

As it is working as intended, adding TE Verified labels.

Please find the attached screencast for reference.

Thanks..!

765389-Mac.mp4
4.2 MB View Download

Comment 15 by sdy@chromium.org, Nov 20 2017

Status: Verified (was: Started)
Thanks, jmukthavaram@!

Comment 16 by sdy@chromium.org, Nov 20 2017

Status: Fixed (was: Verified)
Actually, marking fixed — not verified — until bettes@ confirms that it's right from a design standpoint :)
Design is as intended. Thanks all! 

Comment 18 by sdy@chromium.org, Nov 20 2017

Status: Verified (was: Fixed)

Sign in to add a comment