New issue
Advanced search Search tips

Issue 765347 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Sep 2017
Cc:
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

~WindowTreeClient should delete windows from other clients

Project Member Reported by sky@chromium.org, Sep 14 2017 
If WindowTreeClient is deleted outside of normal shutdown, it's entirely possible we'll leak aura::Windows. In particular any aura::Window that is created with a WindowMusType of OTHER should be explicitly destroyed.

Currently this is really only an issue for the window-manager.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d66e2e4e8d36dcbb8ce69286624685be76663fc4

commit d66e2e4e8d36dcbb8ce69286624685be76663fc4
Author: Scott Violet <sky@chromium.org>
Date: Fri Sep 22 17:19:39 2017

chromeos: make ~WindowTreeClient delete windows of type OTHER

Windows with a type of OTHER were created implicitly by
WindowTreeClient from other clients. It's entirely possible at the
time ~WindowTreeClient is called they were not in a window hierarchy
that would delete them. This patch makes ~WindowTreeClient explicitly
delete them.

BUG= 765347 
TEST=covered by test.

Change-Id: I1c9216b34b851e51c479646296ed79aa259a1351
Reviewed-on: https://chromium-review.googlesource.com/678916
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503776}
[modify] https://crrev.com/d66e2e4e8d36dcbb8ce69286624685be76663fc4/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/d66e2e4e8d36dcbb8ce69286624685be76663fc4/ui/aura/mus/window_tree_client_unittest.cc

Comment 2 by sky@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment