New issue
Advanced search Search tips

Issue 765338 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

ERR_NAME_NOT_RESOLVED refers to "DNS address", which is a weird phrase

Reported by ddrucker...@gmail.com, Sep 14 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36

Steps to reproduce the problem:
1. Navigate to http://thissitedefinitelydoesnotexist123.com/

2. Get ERR_NAME_NOT_RESOLVED error which states "thissitedefinitelydoesnotexist123.com’s server DNS address could not be found.

What is the expected behavior?
A more correct message would be:

thissitedefinitelydoesnotexist123.com’s server IP address could not be found.

What went wrong?
There is no such thing as a 'DNS address'.  DNS is a service that (among other things) maps domain names to IP addresses.

A more correct message would be:

thissitedefinitelydoesnotexist123.com’s server IP address could not be found.

Did this work before? No 

Chrome version: 60.0.3112.113  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 27.0 r0

I suspect this error message has been in there forever, and nobody ever really thought about it... but it's definitely wrong.
 
Components: Internals>Network>DNS
Labels: -Pri-2 OS-Mac Pri-3
Status: Available (was: Unconfirmed)
Confirmed on Chrome Mac 63.0.3215.0 canary.  I presume this is true on all OSes.

Not particularly high priority but from my uneducated UI perspective, IP address would be better than DNS address.



I Will do the required changes .
Uploaded the patch https://chromium-review.googlesource.com/c/chromium/src/+/668380 for your kind consideration.
That patch neglects the mouseover 'definition', which is now out of sync. Also, this needs to happen in all languages, not just English.
1) That patch neglects the mouseover 'definition', which is now out of sync.
So for (1) should I remove the DNS definition or add IP address definition ?

2) Also, this needs to happen in all languages, not just English.

Yeah for that only I modified the error_page_strings.grdp file which when build with the grit Tool (Internal tool ) generates all the xtb files for various languages.
Please correct me if I am wrong , I got this info while searching how to do localization in chromium.
Ah, I understand how (2) works now, ok.

As for (1), I'd just remove the DNS definition.
 
For(1) have removed the DNS definition. Resubmitted the patch for consideration. 
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/928d0a4587a3fb7b51cda85afcd877d31844887a

commit 928d0a4587a3fb7b51cda85afcd877d31844887a
Author: nikhil <nikhil.sahni@samsung.com>
Date: Thu Sep 28 04:57:08 2017

ERR_NAME_NOT_RESOLVED refers to "DNS address" instead of "IP address".

ERR_NAME_NOT_RESOLVED should refer to "IP address" for
a better understanding in case of Page not exist error.

BUG= 765338 


Change-Id: I9669c393e6c1c0f3cd73857010245e8dcc5fa7d1
Reviewed-on: https://chromium-review.googlesource.com/668380
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#504907}
[modify] https://crrev.com/928d0a4587a3fb7b51cda85afcd877d31844887a/components/error_page/common/localized_error.cc
[modify] https://crrev.com/928d0a4587a3fb7b51cda85afcd877d31844887a/components/error_page_strings.grdp

Labels: TE-Verified-M63 TE-Verified-63.0.3227.0 Needs-Milestone
Tested the fix on Mac 10.12.6, Windows 7 using Chrome version #63.0.3227.0  and unable to reproduce the issue.

Observed that on navigating to the link given in comment #1, 'thissitedefinitelydoesnotexist123.com’s server IP address could not be found' is shown as expected.

Attaching screen shot for reference.

Adding the verified labels as the fix is working as intended. 

Thanks..

765338.png
55.3 KB View Download
Status: Fixed (was: Available)

Sign in to add a comment