MediaPlayerRenderer is not muted when the WebContents is muted |
||
Issue descriptionWith the addition of site-wise muting on Android ( crbug.com/743000 ), we will now have muted WebContents on Android. However, videos that use the MediaPlayerRenderer (https://cs.chromium.org/chromium/src/content/browser/media/android/media_player_renderer.cc) (e.g. HLS videos) are still able to make sound since they use the native Android MediaPlayer under the hood
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0325da8db49ed73922ed767d4533d80c97017dd8 commit 0325da8db49ed73922ed767d4533d80c97017dd8 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Oct 17 02:35:28 2017 Mute MediaPlayerRenderers when their WebContents is muted This CL adds MediaPlayerRendererWebContentsObserver to send WebContents muting updates to all MediaPlayerRenderers. The MediaPlayerRenderer then manually mutes itself, since it's not properly muted by WebContent's audio muter. Bug: 765337 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I59714240d507d80258ce200183eb4227718fa460 Reviewed-on: https://chromium-review.googlesource.com/713406 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#509229} [modify] https://crrev.com/0325da8db49ed73922ed767d4533d80c97017dd8/content/browser/BUILD.gn [modify] https://crrev.com/0325da8db49ed73922ed767d4533d80c97017dd8/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/0325da8db49ed73922ed767d4533d80c97017dd8/content/browser/media/android/media_player_renderer.cc [modify] https://crrev.com/0325da8db49ed73922ed767d4533d80c97017dd8/content/browser/media/android/media_player_renderer.h [add] https://crrev.com/0325da8db49ed73922ed767d4533d80c97017dd8/content/browser/media/android/media_player_renderer_web_contents_observer.cc [add] https://crrev.com/0325da8db49ed73922ed767d4533d80c97017dd8/content/browser/media/android/media_player_renderer_web_contents_observer.h
,
Oct 17 2017
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bad9216b09675b779257edfd4dac5da0529645c7 commit bad9216b09675b779257edfd4dac5da0529645c7 Author: Tommy Steimel <steimel@chromium.org> Date: Thu Oct 19 22:12:01 2017 Update MediaPlayerRendererWebContentsObserver comment Updating the comment per miu@'s comments on crrev.com/c/713406 Bug: 765337 Change-Id: I80a1ebaabfa70479f724cb2b86697fc3231db61e Reviewed-on: https://chromium-review.googlesource.com/726385 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#510236} [modify] https://crrev.com/bad9216b09675b779257edfd4dac5da0529645c7/content/browser/media/android/media_player_renderer_web_contents_observer.h |
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Sep 14 2017