New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 765334 link

Starred by 10 users
Status: Fixed
Owner:
robertma@chromium.org
Closed: Dec 2017
Cc:
█ eseidel@chromium.org
qyears...@chromium.org
█ meh@chromium.org
rbyers@chromium.org
█ rafaelw@chromium.org
█ morrita@chromium.org
wolenetz@chromium.org
foolip@chromium.org
█ dglazkov@chromium.org
█ abarth@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 794715


Sign in to add a comment

[WPT Import] Better notification mechanism for imported tests & new failures

Project Member Reported by robertma@chromium.org, Sep 14 2017 
# Background:

Up till now, wpt-import notifies the owner of test directories affected by an automatic import by adding them to the CC list of the import CL. The approach has become more spammy than useful because of:
* the unclear intention (what do we expect owners to do?)
* the low value (the most useful bit, i.e. new failures, is buried deep in the diff of expectations in the CL, and not extracted in the emails)
* and (unnecessarily) high frequency (owners get multiple emails per import, e.g. tryjob/CQ status).
Besides, some teams have not reached the stage to keep a close eye on WPT. And lastly, due to the low information density, the CC mechanism does not really work: regression still goes unnoticed (e.g.  issue 758815 ).

The above is a summary of discussion offline and on blink-dev (https://groups.google.com/a/chromium.org/d/topic/blink-dev/L4-7ZIfMK3Q/discussion).


# Proposed immediate action:

Turn off the CC as the annoyance seems to outweigh its usefulness.


# Long-term plan:

Based on the discussion in the team meeting (https://docs.google.com/document/d/1CmadX7K4AdRuMBTv8kAT1xgUxPCfo9ft6VQTtgw2Y2Y/comment#heading=h.wlik1gmzcacw), we would like to explore some kind of opt-in feature to auto file bugs when a new failure arises from an upstream change. (A clarification: owners should not care about import failures caused by infra issues, which they currently also get notified because of the way Gerrit CC works.) The proposed steps are:

1. Ask stakeholders if they are interested in such a feature. And find some teams that are willing to be the first users.
2. Design and implement the feature based on the feedback.
3. Gradually increase the opt-in rate, which is actually the byproduct of promoting WPT adoption in Chromium.

Comment 1 by robertma@chromium.org, Sep 14 2017 

A relevant effort is being conducted to control the disabled tests in Chrome from which we might be able to learn: go/chrome-disabled-tests (sorry the doc seems to be Googler-only now)

Comment 2 by robertma@chromium.org, Sep 14 2017

Blockedon: 761365

Comment 3 by robertma@chromium.org, Sep 15 2017

Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0b8b7365b0fb1e1c9eb98a7ee7f3b6aeac6a93

commit ef0b8b7365b0fb1e1c9eb98a7ee7f3b6aeac6a93
Author: Robert Ma <robertma@chromium.org>
Date: Fri Sep 15 20:24:12 2017

Stop CCing test owners in wpt-import

Bug:  765334 
Change-Id: I2efd2e25c7cda9bf863f3ca11be2ed7f8065bf8e
Reviewed-on: https://chromium-review.googlesource.com/667728
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502348}
[modify] https://crrev.com/ef0b8b7365b0fb1e1c9eb98a7ee7f3b6aeac6a93/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/ef0b8b7365b0fb1e1c9eb98a7ee7f3b6aeac6a93/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Comment 5 by robertma@chromium.org, Sep 27 2017

Cc: rbyers@chromium.org abarth@chromium.org meh@chromium.org wolenetz@chromium.org morrita@chromium.org eseidel@chromium.org dglazkov@chromium.org rafaelw@chromium.org
 Issue 676672  has been merged into this issue.

Comment 6 by kereliuk@google.com, Nov 29 2017 

Robert, what is the current status of this?

Comment 7 by robertma@chromium.org, Nov 29 2017

Blockedon: -761365
Status: Started (was: Assigned)
Started last week :)

Design doc: https://docs.google.com/document/d/1W3V81l94slAC_rPcTKWXgv3YxRxtlSIAxi3yj6NsbBw/edit

(And it's no longer blocking on issue 761365.)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b954c01f5ed7a37c180cbe745bf2284ebaad34c7

commit b954c01f5ed7a37c180cbe745bf2284ebaad34c7
Author: Robert Ma <robertma@chromium.org>
Date: Thu Dec 07 21:33:33 2017

First stage of WPT import notifier (log all new failures)

Design doc of WPT import notification:
https://docs.google.com/document/d/1W3V81l94slAC_rPcTKWXgv3YxRxtlSIAxi3yj6NsbBw

This CL lays the groundwork. It glues pieces together to find all new
failures after an import, and logs them. Monorail integration is not
added yet. Changes in the code include:

* WPTExpectationsUpdater: change the structure of return values to make
  it easier to consume.
* DirectoryOwnersExtractor: make the API more modular and generic.
* LocalWPT: add support for listing commits, getting commit subjects,
  and checking if a directory is affected by a commit.
* ImportNotifier: the main module of the new import notification system.
* TestImporter: glue everything together.

Bug:  765334 
Change-Id: I59f58510387cdec98c6591c643268fbd1a043394
Reviewed-on: https://chromium-review.googlesource.com/812206
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522555}
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py
[add] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py
[add] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier_unittest.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_mock.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
[modify] https://crrev.com/b954c01f5ed7a37c180cbe745bf2284ebaad34c7/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17a3319b99f6fff27c2954b26cc2813c1b2c1e84

commit 17a3319b99f6fff27c2954b26cc2813c1b2c1e84
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Mon Dec 11 16:47:13 2017

WPT import: Change defaults for notifier-related variables.

Instead of initializing TestImporter's |rebaselined_tests| and
|new_test_expectations| to None, initialize them to the types that
ImportNotifier expects (an iterable and a dict, respectively).

Using None causes the notification mechanisms to fail when a WPT import does
not require any rebaseline changes, as
TestImporter.fetch_new_expecations_and_baselines() is not called and we end
up passing None to ImportNotifier.find_changed_baselines_of_tests() and
ImportNotifier.examine_new_test_expectations().

From https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7427:
Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 25, in <module>
    main()
  File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in main
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 168, in main
    if not self.send_notifications(local_wpt):
  File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 631, in send_notifications
    issue, patchset)
  File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 60, in main
    changed_test_baselines = self.find_changed_baselines_of_tests(rebaselined_tests)
  File "/mnt/data/b/rr/tmpKoSTkX/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 78, in find_changed_baselines_of_tests
    for test_name in rebaselined_tests:
TypeError: 'NoneType' object is not iterable

Bug:  765334 
Change-Id: I36195763226cd393312e80c8819aac546c7daef9
Reviewed-on: https://chromium-review.googlesource.com/819410
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#523111}
[modify] https://crrev.com/17a3319b99f6fff27c2954b26cc2813c1b2c1e84/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier_unittest.py
[modify] https://crrev.com/17a3319b99f6fff27c2954b26cc2813c1b2c1e84/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/17a3319b99f6fff27c2954b26cc2813c1b2c1e84/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d6547d38876429830505493e4cd745629351ffe

commit 1d6547d38876429830505493e4cd745629351ffe
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Tue Dec 12 16:46:01 2017

WPT import: Pass the right variable to ImportNotifier.format_commit_list

ImportNotifier.file_new_failures() calls LocalWPT's commits_in_range()
method, which returns a list of (SHA, commit subject) pairs.

It was then passing this list of tuples directly to format_commit_list(),
which expects a simple list of hashes instead, which led to failures such
as:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 25, in <module>
    main()
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in main
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 168, in main
    if not self.send_notifications(local_wpt):
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 631, in send_notifications
    issue, patchset)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 64, in main
    self.file_new_failures(wpt_revision_start, wpt_revision_end, issue, gerrit_url)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 179, in file_new_failures
    commit_list = self.format_commit_list(imported_commits, full_directory)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py", line 199, in format_commit_list
    line = '{}: {}'.format(self.local_wpt.commit_subject(commit), GITHUB_COMMIT_PREFIX + commit)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py", line 191, in commit_subject
    output = self.run(['git', 'show', '--format=%s', '-q', commit])
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py", line 50, in run
    return self.host.executive.run_command(command, cwd=self.path, **kwargs)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 337, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/data/b/rr/tmpObTKGC/w/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 244, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'show', '--format=%s', '-q', (u'a4c37295163abd475704cc032a304c83b14f9202', u'Add tests for slot.assignedElements method (#8636)')]" exit_code: 128 cwd: /tmp/wpt
output: fatal: ambiguous argument '(u'a4c37295163abd475704cc032a304c83b14f9202', u'Add tests for slot.assignedElements method (#8636)')': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
step returned non-zero exit code: 1
(via https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7486)

Bug:  765334 
Change-Id: Iec2f574e5c308cd10f028e9ad1496be7967c0843
Reviewed-on: https://chromium-review.googlesource.com/822253
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#523450}
[modify] https://crrev.com/1d6547d38876429830505493e4cd745629351ffe/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01db109d77307f172bef9049f4794aeec65a47b5

commit 01db109d77307f172bef9049f4794aeec65a47b5
Author: Robert Ma <robertma@chromium.org>
Date: Wed Dec 13 15:57:06 2017

Refactor DirectoryOwnersExtractor to make it more useful

DirectoryOwnersExtractor.find_owners_file is made more generic to
accommodate the new usage in ImportNotifier:
* It does not skip "empty" OWNERS (those without emails) any more, which
  allows "# WPT-NOTIFY" to be added to OWNERS files with comments only
  (e.g. "# TEAM", "# COMPONENT" lines; there are a bunch in wpt).
* It may now return LayoutTests/external/OWNERS. This is to make sure
  owners can always be found for WPT files so that ImportNotifier can
  generate and log bugs for all failures (but we will never turn on
  WPT-NOTIFY there).
* It can now take four variants of paths: (absolute, relative) X (file,
  directory), to make it easier to use.

Previous heuristics like skipping empty OWNERS are moved to list_owners
instead, which is only used for generating a list of owners in commit
messages and may eventually be removed.

Also improve the setup of the unit test of this module.

Bug:  765334 
Change-Id: I01bd1fa85d2602299eaf1e0d8e0872b04b93a008
Reviewed-on: https://chromium-review.googlesource.com/822834
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523781}
[modify] https://crrev.com/01db109d77307f172bef9049f4794aeec65a47b5/third_party/WebKit/LayoutTests/external/OWNERS
[modify] https://crrev.com/01db109d77307f172bef9049f4794aeec65a47b5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py
[modify] https://crrev.com/01db109d77307f172bef9049f4794aeec65a47b5/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

Comment 13 by robertma@chromium.org, Dec 13 2017

Blockedon: 794715
Deploying credentials
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10c9d63837ea614fb13a4e216c3d73232b4b83c3

commit 10c9d63837ea614fb13a4e216c3d73232b4b83c3
Author: Robert Ma <robertma@chromium.org>
Date: Wed Dec 13 22:30:06 2017

Second stage of WPT import notifier: Monorail integration

With this CL, we should have full Monorail integration, but the switch
is *not* turned on yet ('--auto-file-bugs' needs to be added to the
recipe to actually enable Monorail API).

The CL introduces a simple abstraction for Monorail issues and API,
which also helps testing. Dependencies of Monorail API are introduced
via wpt-import.vpython. See vpython docs:
https://chromium.googlesource.com/infra/infra/+/master/doc/users/vpython.md#script_specific-specification

Lastly, LocalWPT.commit_subject is removed as the information is
already available through LocalWPT.commits_in_range.

Bug:  765334 
Change-Id: Ia0f2f8d1ba34301e7756ac6ac25bcae8c4235579
Reviewed-on: https://chromium-review.googlesource.com/820813
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523914}
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier_unittest.py
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_mock.py
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[add] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail.py
[add] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail_unittest.py
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
[modify] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/wpt-import
[add] https://crrev.com/10c9d63837ea614fb13a4e216c3d73232b4b83c3/third_party/WebKit/Tools/Scripts/wpt-import.vpython
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ebf7ba4f3059377fb7e9e52401b65ab0f0fcc9b

commit 0ebf7ba4f3059377fb7e9e52401b65ab0f0fcc9b
Author: Robert Ma <robertma@chromium.org>
Date: Thu Dec 14 17:50:46 2017

Fix two bugs in monorail.py found in local testing

Bug:  765334 
Change-Id: I8b88d07d40314fb3c4554530e3e1918f301b0202
Reviewed-on: https://chromium-review.googlesource.com/827035
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524107}
[modify] https://crrev.com/0ebf7ba4f3059377fb7e9e52401b65ab0f0fcc9b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail.py
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/053af45b1495b167cda195bfea3c03a423d8d8c2

commit 053af45b1495b167cda195bfea3c03a423d8d8c2
Author: Robert Ma <robertma@chromium.org>
Date: Fri Dec 15 16:58:41 2017

Work around a Monorail API bug ('cc' field in issue body)

The type of 'cc' field is inconsistent with the API docs. Marshal the
field to work around the bug for now.

Bug:  765334 ,  monorail:3300 
Change-Id: I1b252b649b665e77ff643b34b87ce9587723db0d
Reviewed-on: https://chromium-review.googlesource.com/826186
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524397}
[modify] https://crrev.com/053af45b1495b167cda195bfea3c03a423d8d8c2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail.py
[modify] https://crrev.com/053af45b1495b167cda195bfea3c03a423d8d8c2/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail_unittest.py
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e7128132d832c7ef15410cfc9ea84dca858599ae

commit e7128132d832c7ef15410cfc9ea84dca858599ae
Author: Robert Ma <robertma@chromium.org>
Date: Fri Dec 15 18:50:18 2017

Provide wpt-import with the SA private key to access Monorail

Only set up the credentials now, not turning on '--auto-bug-filing' just
yet. An ad-hoc end-to-end test will be conducted later, before actually
flipping the switch.

Also add myself to the OWNERS of WPT recipes and test expectations.

Bug:  765334 , 794715
Change-Id: I1279ec7b796ace191a63a6702eef4c19736c00e1
Reviewed-on: https://chromium-review.googlesource.com/826427
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>

[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/recipes/OWNERS
[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/recipes/wpt_import.expected/wpt-import-with-issue.json
[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/recipes/wpt_import.expected/OWNERS
[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/README.recipes.md
[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/recipes/wpt_import.py
[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/recipes/wpt_export.expected/OWNERS
[modify] https://crrev.com/e7128132d832c7ef15410cfc9ea84dca858599ae/recipes/recipes/wpt_import.expected/wpt-import-without-issue.json
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f343805fb6ff24be1651b5352683b626a181d8

commit 83f343805fb6ff24be1651b5352683b626a181d8
Author: Robert Ma <robertma@chromium.org>
Date: Fri Dec 15 21:41:17 2017

TEST: file a bug to staging right after wpt-import starts

This is a live end-to-end test to ensure Monorail integration and
credential deployment work correctly on bots. This CL will be reverted
once a bug is successfully filed to monorail-staging.appspot.com.

Bug:  765334 , 794715
Change-Id: I3b9d94116286e8d5c1daf24961af1de5d8b5e63e
Reviewed-on: https://chromium-review.googlesource.com/830193
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524470}
[modify] https://crrev.com/83f343805fb6ff24be1651b5352683b626a181d8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail.py
[modify] https://crrev.com/83f343805fb6ff24be1651b5352683b626a181d8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b2dc6a3f833381397e69375f1baa746c591e18d

commit 6b2dc6a3f833381397e69375f1baa746c591e18d
Author: Robert Ma <robertma@chromium.org>
Date: Fri Dec 15 21:54:48 2017

Revert "TEST: file a bug to staging right after wpt-import starts"

This reverts commit 83f343805fb6ff24be1651b5352683b626a181d8.

Reason for revert: WOOHOO! It worked as intended :)

Original change's description:
> TEST: file a bug to staging right after wpt-import starts
> 
> This is a live end-to-end test to ensure Monorail integration and
> credential deployment work correctly on bots. This CL will be reverted
> once a bug is successfully filed to monorail-staging.appspot.com.
> 
> Bug:  765334 , 794715
> Change-Id: I3b9d94116286e8d5c1daf24961af1de5d8b5e63e
> Reviewed-on: https://chromium-review.googlesource.com/830193
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524470}

TBR=qyearsley@chromium.org,robertma@chromium.org

Change-Id: I19ffc37c8d71f31ec4e8ed56066b0d896b0bb301
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  765334 , 794715
Reviewed-on: https://chromium-review.googlesource.com/831006
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524475}
[modify] https://crrev.com/6b2dc6a3f833381397e69375f1baa746c591e18d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/monorail.py
[modify] https://crrev.com/6b2dc6a3f833381397e69375f1baa746c591e18d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3fdac8140d1da2dab00af34e99d8153b12674923

commit 3fdac8140d1da2dab00af34e99d8153b12674923
Author: Robert Ma <robertma@chromium.org>
Date: Mon Dec 18 20:19:36 2017

Finally turn on --auto-file-bugs for wpt-import

This flips the switch to turn on WPT Import Notification and concludes
the project.

Bug:  765334 
Change-Id: I4326597dfbfb0ce56c27e76f1d2995d5a0f95409
Reviewed-on: https://chromium-review.googlesource.com/830708
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>

[modify] https://crrev.com/3fdac8140d1da2dab00af34e99d8153b12674923/recipes/recipes/wpt_import.expected/wpt-import-with-issue.json
[modify] https://crrev.com/3fdac8140d1da2dab00af34e99d8153b12674923/recipes/recipes/wpt_import.expected/wpt-import-without-issue.json
[modify] https://crrev.com/3fdac8140d1da2dab00af34e99d8153b12674923/recipes/README.recipes.md
[modify] https://crrev.com/3fdac8140d1da2dab00af34e99d8153b12674923/recipes/recipes/wpt_import.py
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c515acc221178886a654c6f2dd5ef930ce3d48be

commit c515acc221178886a654c6f2dd5ef930ce3d48be
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Dec 19 10:06:04 2017

Enable wpt import notifcations for compat/ and fullscreen/

Drive-by: remove foolip@ from webvtt/ (not doing any work there)

Bug:  765334 
Change-Id: Ifd634f93a64a0e7feb6aa5be53fe171a05ba2531
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/831988
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524988}
[modify] https://crrev.com/c515acc221178886a654c6f2dd5ef930ce3d48be/third_party/WebKit/LayoutTests/external/wpt/compat/OWNERS
[modify] https://crrev.com/c515acc221178886a654c6f2dd5ef930ce3d48be/third_party/WebKit/LayoutTests/external/wpt/fullscreen/OWNERS
[modify] https://crrev.com/c515acc221178886a654c6f2dd5ef930ce3d48be/third_party/WebKit/LayoutTests/external/wpt/webvtt/OWNERS
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31e7c27b6189599f22706ed5bd2476a0096c2671

commit 31e7c27b6189599f22706ed5bd2476a0096c2671
Author: Robert Ma <robertma@chromium.org>
Date: Tue Dec 19 15:08:42 2017

Correctly mark affecting commits in the list of commits

Paths in Chromium repo were incorrectly passed to
LocalWPT.is_commit_affecting_directory. This CL fixes it by making the
paths relative to wpt/.

Bug:  765334 
Change-Id: I2ff1b5d07db64ad0fc98eb0fdc06ff8d8e1d8e94
Reviewed-on: https://chromium-review.googlesource.com/833186
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525035}
[modify] https://crrev.com/31e7c27b6189599f22706ed5bd2476a0096c2671/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier.py
[modify] https://crrev.com/31e7c27b6189599f22706ed5bd2476a0096c2671/third_party/WebKit/Tools/Scripts/webkitpy/w3c/import_notifier_unittest.py

Comment 24 by robertma@chromium.org, Dec 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment