Bookmarks list and edit views overlap with camera and sensor shelf on iPhoneX in landscape mode |
||||||||||||
Issue descriptionApp Version: 63.0.3215.0 iOS Version: iOS11 Device: iPhoneX Sim URL: Bookmarks Steps to reproduce: 1. Launch app 2. Tap the Star on NTP for bookmarks 3. Turn device to landscape mode Observed results: Observe the left side of the bookmarks overlaps with the camera and sensor shelf in landscape mode. On the right side it will overlap the edit options. These overlaps happen in Edit/Move modes as well. Expected results: No overlap should occur. Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_SzNWQmJVUC1RRjQ/view https://drive.google.com/file/d/0By4O1f2IQqQ_SWdWSF9adnJJZGc/view
,
Sep 15 2017
,
Sep 20 2017
This impacts feature usability. Setting to M63 RBS.
,
Sep 21 2017
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b701428aa2a98d01de2ec1fd27a9227ca5684eb commit 6b701428aa2a98d01de2ec1fd27a9227ca5684eb Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Thu Sep 21 17:00:29 2017 Fix bookmarks on iPhone X. Fixes toolbars (standard and edit) and bookmark list to respect the safe areas. The fixes are not great, but seem to be acceptable since bookmarks will soon be replaced with new bookmarks. Bug: 765308 Change-Id: I5c9fd374eee251cfca5ddecdc71ea4cbecb5b86e Reviewed-on: https://chromium-review.googlesource.com/677384 Reviewed-by: Eric Noyau <noyau@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503477} [modify] https://crrev.com/6b701428aa2a98d01de2ec1fd27a9227ca5684eb/ios/chrome/browser/ui/bookmarks/bars/bookmark_navigation_bar.mm [modify] https://crrev.com/6b701428aa2a98d01de2ec1fd27a9227ca5684eb/ios/chrome/browser/ui/bookmarks/bars/bookmark_top_bar.mm [modify] https://crrev.com/6b701428aa2a98d01de2ec1fd27a9227ca5684eb/ios/chrome/browser/ui/bookmarks/bookmark_collection_cells.mm
,
Sep 22 2017
,
Oct 26 2017
Toolbars looking good. Bookmarks list is respecting the safe areas now. Verified on iPhoneX Simulator M64.0.3251.0 canary, M63.0.3239.19 beta Bookmarks Edit UI Screen still doesn't respect safearea.(Screenshot#2 from comment#0) With old Bookmarks UI and New Gen Bookmarks UI. Let me know if we need to file a new bug for that.
,
Oct 31 2017
@stk was your fix supposed to address the list and edit views of Bookmarks?
,
Nov 6 2017
Ping @stk?
,
Nov 6 2017
I'm sorry, I completely missed the list aspect, and since this was verified, I never saw this bug again. I'll take a look
,
Nov 6 2017
The _edit_ aspect, not the list aspect, sorry for possible confusion.
,
Nov 7 2017
So I looked at it, and this is fine on trunk, but broken on 63. The fix is in MDC, so I see three options: 1. Do nothing, because this is only broken in Landscape on iPhone X, and it's not unusable. Looks totally fine in Portrait. 2. Cherry-pick an MDC roll and possibly a piper roll into M63. 3. Write a small cherry-pickable fix specifically for M63 and let the branch diverge from trunk. I think 2 is very risky and hard. 3 is pretty ugly and it's not a great idea to diverge M63, since this is not something we generally do. So I prefer to keep it as is; especially given that landscape usage on phones is low and bookmarks usage is low, too. +pkl, you were the main POC for the piper/MDC rolls lately, could you say how you feel about option 2?
,
Nov 8 2017
Assigning to pkl@ for feedback. Please return to me :)
,
Nov 10 2017
For M63, we will launch Bookmarks NG which does not have the same problem to 100%. I think the answer is actually "WontFix". Reassigning back to stk@ to actually WontFix this bug. Removing ReleaseBlock-Stable at this time.
,
Nov 13 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by jif@chromium.org
, Sep 15 2017Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)