Back button menu overlaps with camera and sensor shelf on iPhoneX in landscape mode |
|||||||||
Issue descriptionApp Version: 63.0.3215.0 iOS Version: iOS11 Device: iPhoneX Sim URL: Back button Steps to reproduce: 1. Launch app 2. Open new tab and navigate to a site 3. Turn the phone to landscape mode 4. Long tap on the back button Observed results: Observe the back button menu overlaps with camera and sensor shelf on iPhoneX in landscape mode Expected results: Back button menu shouldn't overlap with camera and sensor shelf on iPhoneX in landscape mode Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_SXhzRDVGdW56OWc/view
,
Sep 15 2017
,
Sep 20 2017
M63 RBS because parts of the dropdown menu is blocked.
,
Sep 21 2017
To jif@ because he's already working on another part of toolbar and iPhone X + as owner of toolbar
,
Oct 19 2017
Taking it.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf38224605234c859e7d73b9f5883180bf116524 commit bf38224605234c859e7d73b9f5883180bf116524 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Oct 19 14:51:28 2017 Toolbar content respects safe area The content of the toolbar needs to respect the safe area. This CL fixes the content displayed outside of the safe area by creating a contentView respecting the safe area boundaries. The content is added to this view instead of the ToolbarView. This also makes the back menu dropdown to be displayed inside the safe area. It also dismisses it during device rotation. Bug: 765304 , 776340 , 764877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4f5b8499644b0b406a94a723bde1a6d80928cd0 Reviewed-on: https://chromium-review.googlesource.com/727890 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510083} [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/toolbar/toolbar_controller.h [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/toolbar/toolbar_controller.mm [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm [modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
,
Oct 19 2017
,
Oct 20 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13b3c197c20a787abb76e7069db77c80a486bea0 commit 13b3c197c20a787abb76e7069db77c80a486bea0 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Oct 23 06:30:16 2017 Toolbar content respects safe area The content of the toolbar needs to respect the safe area. This CL fixes the content displayed outside of the safe area by creating a contentView respecting the safe area boundaries. The content is added to this view instead of the ToolbarView. This also makes the back menu dropdown to be displayed inside the safe area. It also dismisses it during device rotation. Bug: 765304 , 776340 , 764877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4f5b8499644b0b406a94a723bde1a6d80928cd0 Reviewed-on: https://chromium-review.googlesource.com/727890 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510083}(cherry picked from commit bf38224605234c859e7d73b9f5883180bf116524) Reviewed-on: https://chromium-review.googlesource.com/732817 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#146} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/toolbar/toolbar_controller.h [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/toolbar/toolbar_controller.mm [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm [modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
,
Oct 24 2017
Verified on 64.0.3249.0 canary iPhoneX Simulator. Screenshot: https://drive.google.com/file/d/16hEX2jsolpxpG2mrIm7lVDB9LzKuUddE/view
,
Oct 26 2017
Verified in M63.0.3239.19 beta iPhoneX Simulator |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jif@chromium.org
, Sep 15 2017Status: Assigned (was: Untriaged)