New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The echo canceller3 alignment functionality may get stuck in a noncausal state during capture data loss

Project Member Reported by peah@chromium.org, Sep 14 2017

Issue description

For certain variants of loss of capture data the alignment function in AEC3 may end up in a noncausal state, and the only way to exit that is to have additional capture data loss.

In practice this means that there is a nonzero risk of sustained echo (due to canceller failure) when there is loss of capture data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/930021d465cc1bcf7e14fd56fdbbe463a38f7678

commit 930021d465cc1bcf7e14fd56fdbbe463a38f7678
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Sep 15 21:24:46 2017

Eliminating the risk of sustained echo during capture data loss in AEC3.

This CL adds an offset to the delay estimation used in AEC3 for 
determining the alignment between the render and capture signals.
This ensures that there is no possibility for the capture loss to 
cause the delay estimation to miss aligning the signals.

BUG= webrtc:8247 ,  chromium:765242 

Change-Id: I526dc7971b13425a28e99d69168fd3722a4cfdae
Reviewed-on: https://webrtc-review.googlesource.com/1232
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#19871}
[modify] https://crrev.com/930021d465cc1bcf7e14fd56fdbbe463a38f7678/modules/audio_processing/aec3/render_delay_controller.cc
[modify] https://crrev.com/930021d465cc1bcf7e14fd56fdbbe463a38f7678/modules/audio_processing/aec3/render_delay_controller_unittest.cc

Comment 2 by peah@chromium.org, Sep 22 2017

Cc: hlundin@chromium.org
Labels: Merge-Request-62
This has now successfully been tested in Canary in explorative calls. 

This feature is beneath a experiment which is active 50% in Canary, Dev and Beta, and the UMA stats for the CL fixing this issue looks good.

I would, if possible, like this CL to be merged into M62. Note that all the effects of this change is beneath an experimental flag.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 22 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Approving merge to M62. Branch:3202
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25 2017

Labels: merge-merged-62
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/6f21dc245689c29730002da09534a8d275e6aa92

commit 6f21dc245689c29730002da09534a8d275e6aa92
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Sep 25 20:58:47 2017

Merge of Eliminating the risk of sustained echo during capture data loss in AEC3.

This CL adds an offset to the delay estimation used in AEC3 for
determining the alignment between the render and capture signals.
This ensures that there is no possibility for the capture loss to
cause the delay estimation to miss aligning the signals.

BUG= webrtc:8247 ,  chromium:765242 
TBR=aleloi@webrtc.org

(cherry picked from commit 930021d465cc1bcf7e14fd56fdbbe463a38f7678)

Change-Id: I526dc7971b13425a28e99d69168fd3722a4cfdae
Reviewed-on: https://webrtc-review.googlesource.com/1232
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Original-Commit-Position: refs/heads/master@{#19871}
Reviewed-on: https://webrtc-review.googlesource.com/3040
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/branch-heads/62@{#12}
Cr-Branched-From: 85e6a4ba1372f21b8648ffaad2fd19a76a8bb316-refs/heads/master@{#19592}
[modify] https://crrev.com/6f21dc245689c29730002da09534a8d275e6aa92/webrtc/modules/audio_processing/aec3/render_delay_controller.cc
[modify] https://crrev.com/6f21dc245689c29730002da09534a8d275e6aa92/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Sep 26 2017

Cc: abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by peah@chromium.org, Sep 27 2017

Labels: -Merge-Approved-62
Status: Fixed (was: Assigned)

Sign in to add a comment