New issue
Advanced search Search tips

Issue 765235 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Do not pass security origin to MediaStreamDispatcherHost

Project Member Reported by guidou@chromium.org, Sep 14 2017

Issue description

Instead get it from the frame.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3298e19f82e0297653b4eb3a52e67ee87bacf371

commit 3298e19f82e0297653b4eb3a52e67ee87bacf371
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Oct 16 11:08:08 2017

Do not cache device ID salt in MediaDevicesDispatcherHost.

This is the first in a series of CLs to remove caching of the device ID
salt in the following browser objects:
-MediaDevicesDispatcherHost
-MediaStreamDispatcherHost
-AudioRendererHost

The salt can be reset by the user at any time by clearing browsing data.
Caching it leads to using a stale salt, which results in noncompliance
with the spec, which requires user-visible device IDs to be reset when
cookies are cleared.
Furthermore, the objects mentioned above have different lifetimes, which
leads to inconsistencies if a user clears browsing data.

Bug:  765302 ,  765235 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: If6123b7991084ad92809b20faa5f672fcb3061f2
Reviewed-on: https://chromium-review.googlesource.com/708737
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509016}
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/content/browser/media/media_devices_util.cc
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/content/browser/media/media_devices_util.h
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/content/browser/renderer_host/media/media_devices_dispatcher_host.h
[modify] https://crrev.com/3298e19f82e0297653b4eb3a52e67ee87bacf371/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc

Comment 2 by guidou@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment