“Search and Site suggestions” text is not translated to device locale |
||||||||||
Issue descriptionApp Version: 62.0.3202.23 beta iOS Version: 10.3.3,11.0 Device : iPhone,iPad Precondition : 1- Enable content suggestions. 2- Change the device language from device settings to any language other than english. Steps to reproduce: 1. Launch chrome 2. Tap on Menu > Settings > Privacy. Observed results: “Search and Site suggestions” text is not translated to device locale. Expected results: “Search and Site suggestions” text should be translated to device locale. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Yes Bug reproducible on Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): No in m61, New change Implementation from 62 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M62 Link to Image : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpTmlUQWxfUm5mVFU/view?usp=sharing
,
Sep 14 2017
Over to Sergio for Settings.
,
Sep 18 2017
,
Sep 24 2017
I hope this is an easy fix. We should not launch without proper localized strings. I will mark this as an RBS.
,
Sep 25 2017
Verified the issue on the build 62.0.3202.34 beta tested on iPhone5C(10.3),iPad(9.3.5) & iPhone7+(11.0). “Search and Site suggestions” text is translated to device locale.looks good.
,
Sep 25 2017
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25 2017
@pmadalla: Thanks. So if this is fixed, please mark it as such (verified I guess).
,
Sep 25 2017
Settings had always supported this to use the String ID instead of the String itself. I checked that gambard@ made updated to the String value in late August, so it might be that the String wasn't translated when this issue was reported but it is now. I think its safe to say that this has been fixed. CCing gambard@ just as an FYI.
,
Sep 26 2017
,
Sep 26 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 7 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by pmadalla@chromium.org
, Sep 14 2017