New issue
Advanced search Search tips

Issue 765154 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 764848
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Sometimes "git cl upload" creates a CL but does not set cc:

Project Member Reported by sdefresne@chromium.org, Sep 14 2017

Issue description

I ran "git cl upload" today, and got this result:

$ git cl upload
Running presubmit upload checks ...

Presubmit checks took 2.4s to calculate.

Presubmit checks passed.
 ios/chrome/browser/ui/ui_util.h  | 2 ++
 ios/chrome/browser/ui/ui_util.mm | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
remote: Processing changes: new: 1, done            
remote: (W) aa805a9: commit subject >50 characters; use shorter first paragraph        
remote: 
remote: New Changes:        
remote:   https://chromium-review.googlesource.com/#/c/chromium/src/+/667156 Implements IsIPadIdiom using ui::GetDeviceFormFactor().        
remote: 
To https://chromium.googlesource.com/chromium/src.git
 * [new branch]                aa805a91f6955205b7fcf3f63f931c4987501588 -> refs/for/refs/heads/master%wip,m=Initial_upload

Error after CL description prompt -- saving description to /Users/sdefresne/.git_cl_description_backup

Created|Updated 0 issues on Gerrit, but only 1 expected.
Change-Id: Ib1d92a794f4ddc1a8b53d05fe6b581d0b3c8e6f5

You can check https://chromium-review.googlesource.com/#/c/chromium/src/+/667156 was created, "git cl" though no issue was associated with the current branch and no cc: where added to the CL.

$ git cl web
ERROR No issue to open

 

Comment 1 by whesse@google.com, Sep 14 2017

Mergedinto: 765035
Status: Duplicate (was: Untriaged)

Comment 2 by whesse@google.com, Sep 14 2017

Status: Untriaged (was: Duplicate)

Comment 3 by whesse@google.com, Sep 14 2017

Cc: aga...@chromium.org
 Issue 765023  has been merged into this issue.

Comment 4 by whesse@google.com, Sep 14 2017

Components: Infra>Codereview>Gerrit Infra>SDK
Labels: -Pri-3 Pri-1
Multiple users in our office have been hitting this issue today.

The issue is created but git cl issue returns empty.
The cc or reviewer is also not added to the issue.


Comment 5 by sortie@google.com, Sep 14 2017

Cc: sortie@google.com

Comment 6 by aga...@chromium.org, Sep 14 2017

Mergedinto: -765035 764848
Status: Duplicate (was: Untriaged)

Sign in to add a comment