Regression: Unnecessary all content gets selected in chrome://credits after clicking on show license/hide license
Reported by
nutan.ga...@etouch.net,
Sep 14 2017
|
||||||
Issue descriptionChrome Version: 63.0.3215.0 c0a8c2aa2c837f8d182cde8f08b51b1c9543dbdd-refs/heads/master@{#501821} OS: Windows (7,8,10), Linux(14.04), Mac(10.11.6, 10.12.3, 10.12.5) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://credits/ 2. Click on ‘show license’ then double click on ‘hide license’ and observe Actual: Unnecessary all content gets selected in chrome://credits after clicking on show license/hide license Expected: All content should not get selected in chrome://credits after clicking on show license/hide license This is an Regression issue broken in M-62. Good Build: 62.0.3167.0 Bad Build: 62.0.3168.0 You are probably looking for a change made after 489591 (known good), but no later than 489592 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/107b926d47ea8967edcb15a63024eb4736319d7e..5252bf14ab5992b9633257b532157ef21128c687 Suspect: https://chromium.googlesource.com/chromium/src/+/5252bf14ab5992b9633257b532157ef21128c687 @yoichio: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
,
Sep 14 2017
1?: [LOCALHOST] pmtu 1500 1: 10.208.1.1 2.895ms 1: 10.208.1.1 3.248ms 2: 10.100.200.100 2.677ms 3: Sonic4500.alsd.k12.ca.us 2.635ms 4: 163.150.231.254 2.867ms 5: cn-nat-232-33.sbcss.k12.ca.us 3.033ms 6: 163.150.224.1 4.199ms 7:
,
Sep 15 2017
<style>
input + label + div {
display: none;
}
input + label::after {
content: "show license";
cursor: pointer;
}
input:checked + label + div {
display: block;
}
input:checked + label::after {
content: "hide license";
cursor: pointer;
}
</style>
<input type="checkbox" style="display:none" id="i1" /><label for="i1"></label>
<div>foo</div>
<div>bar</div>
In that case, double click the label selects "bar" at least on M61.
I think this is not regression in Blink.
,
Sep 21 2017
I synced back to 5252bf14ab5992b9633257b532157ef21128c687 via gclient sync --disable-syntax-validation --revision 5252bf14ab5992b9633257b532157ef21128c687 and confirmed the bug, then reverted 5252bf14ab5992b9633257b532157ef21128c687 and confirmed that the bug no longer occurred. So this does appear to be a regression caused by 5252bf14ab5992b9633257b532157ef21128c687.
,
Sep 25 2017
s = getSelection()
Selection {anchorNode: label.show, anchorOffset: 0, focusNode: span.title, focusOffset: 0, isCollapsed: false, …}
That means this content is selected and work as intent.
See attached screenshot.
It seems that "homepage" and "hide license" was swapped each other between M61 and M62.
That causes double-click "hide license" select elements.
,
Sep 28 2017
This is not a 'Stable' blocker since it's not blocking any chrome functionality.
,
Jul 27
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ranjitkan@chromium.org
, Sep 14 2017