Issue metadata
Sign in to add a comment
|
Omnibox is displayed in the top of the NTP page |
||||||||||||||||||||
Issue descriptionApp Version: 62.0.3202.21 beta iOS Version: 9.3.5, 10.3.3, 11.0 Device: iPhone Steps to reproduce: 1. Launch chrome 2. Tap on omnibox and search anything 3. Once google search result page is displayed, tap on back button Observed results: Notice the omnibox is displayed at the top of the NTP page Expected results: The normal NTP page should be displayed i.e. NTP page that displays when app launch or opening new tap page. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: No Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M61 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M62 Link to video/image: Behavior in M62: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8Z0tTNnN2RlNWUjA/view?usp=sharing Behavior in stable M61: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8bHhGUnhpUUpSZjg/view?usp=sharing
,
Sep 14 2017
Discussed with Gauthier offline. I think this behaviour feels weird. I prefer to fix this for M62 if at all possible. Gauthier will assess complexity and risk of cherry-picking and get back to us. Otherwise, it will be fixed in M63.
,
Sep 14 2017
I agree, thanks for surfacing Gauthier.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59916f5aa8890f08bec1183d401d81c1a404f64e commit 59916f5aa8890f08bec1183d401d81c1a404f64e Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 15 13:15:23 2017 Save NTP position before the omnibox is moved When navigating away from the NTP, the position saved should take into account the fact that the omnibox is automatically lifted up when focused. When navigating back to the NTP, the position restored should be the one used before the lift of the fake omnibox. Bug: 765151 Change-Id: I52a1d09252f2eac2ffb0fc997681d936de54c886 Reviewed-on: https://chromium-review.googlesource.com/668364 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#502237} [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.h [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/content_suggestions/ntp_home_test_utils.h [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/content_suggestions/ntp_home_test_utils.mm [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/59916f5aa8890f08bec1183d401d81c1a404f64e/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.h
,
Sep 15 2017
Fixed and the fix should be safe enough to be landed on M62.
,
Sep 15 2017
This bug requires manual review: Less than 28 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 18 2017
+cmasso@ for merge review.
,
Sep 19 2017
Tapping on omnibox is currently broken (Issue 766455) We will verify this bug once http://crbug/766455 is fixed.
,
Sep 21 2017
Please re-take a look Srikanth
,
Sep 21 2017
Looks Good. NTP is displayed correctly on navigating back from Google SRP. Verified with and without Content Suggestions feature. Verified on iPhone7 plus, iOS11 M63.0.3221.0 canary.
,
Sep 21 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52aa9176248d97ec122664939dca86d62c61cbcd commit 52aa9176248d97ec122664939dca86d62c61cbcd Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 22 09:43:21 2017 Save NTP position before the omnibox is moved When navigating away from the NTP, the position saved should take into account the fact that the omnibox is automatically lifted up when focused. When navigating back to the NTP, the position restored should be the one used before the lift of the fake omnibox. Cherry-picked from: https://chromium-review.googlesource.com/668364 Bug: 765151 Change-Id: I7e2db2abd51f4669db422fb92aa12629a358a4e6 Reviewed-on: https://chromium-review.googlesource.com/678497 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#396} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/52aa9176248d97ec122664939dca86d62c61cbcd/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/52aa9176248d97ec122664939dca86d62c61cbcd/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.h [modify] https://crrev.com/52aa9176248d97ec122664939dca86d62c61cbcd/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/52aa9176248d97ec122664939dca86d62c61cbcd/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/52aa9176248d97ec122664939dca86d62c61cbcd/ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.h
,
Sep 27 2017
Verified in: App Version: 62.0.3202.35 beta Devices: iPhone 5, iPhone 6, iPad Air iOS Versions: 9.3.5, 10.3.3, 11.0 NTP is displayed correctly when navigating back from Google search page. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by gambard@chromium.org
, Sep 14 2017Owner: amyroberts@chromium.org
Status: Assigned (was: Untriaged)