New issue
Advanced search Search tips

Issue 765106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 716053



Sign in to add a comment

[Dice] AccountReconcilor behavior when tokens are not loaded

Project Member Reported by droger@chromium.org, Sep 14 2017

Issue description

Looking at the code there seems to be a bug when StartReconcile() is called when the tokens are not loaded yet.
In that case, the reconcilor seems to be put in a bad state and stop working completely. There is also no test covering this.

The problem already exists with Mirror, but may possibly be more likely to happen with Dice because tokens may load slower on desktop.

Even if there is no bug, the current design seems odd (letting the reconcile hang midway seems dangerous). A cleaner solution would probably to prevent reconcile from starting at all until the tokens are loaded, and make sure it is called when the tokens are loaded (which is not currently the case).

A test should be added.
 

Comment 2 by droger@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment