reeveman@ - Can you look into this while you're changing the UI and make sure that keyboard controls work as expected in general?

This is sort of working as intended. The discard button is getting focus when 'Existing photo from camera or file' is selected but I agree that this is not the ideal behavior. Setting pages don't really have a 'Done' or 'Apply' button that we can move focus to so not sure what we should move focus to after capturing a picture. Maybe we can move it to the 'Back' button that takes the user back to the previous page. Assigning to UX for recommendations before making any changes.

On a related note; For oobe UI we should probably make sure focus is moved to the 'Done' button after capture if that's not already the case.

+ mcirimele@ for interaction 

I think the way we should solve this is by moving focus from the delete button to the photo in the avatar list. Right now we are showing visual focus there and that is what I would expect. Pressing enter on an avatar in focus has no effect and we should do the same when the avatar is a photo. 

This bug is very related to  issue 767820 , maybe one gets fixed by the other?

Let me know if you need a more formal description of the behavior and I'll put it together. 

hcarmona@, you made some input focus changes to fix accessibility issues. any chance you have cycles to improve this? assign back to me if not.

Any updates?

Taking a look at this today

Uploaded CL for review: https://crrev.com/c/764594

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4e5fdd3f018ead78e22e62d6a5a1943e0014598

commit d4e5fdd3f018ead78e22e62d6a5a1943e0014598
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Nov 14 19:39:18 2017

Focus action button instead of triggering in profile picture chooser.

This improves accessibility behavior by focusing the button that will
perform the action when the selected item is pressed. Before, this
would have deleted a user photo or taken a photo. The new behavior
moves focus to a button that is properly labeled.

Bug:  765104 , 767820 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8b813a9d53c0e5b47579274253c173fc4294404f
Reviewed-on: https://chromium-review.googlesource.com/764594
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516391}
[modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/chrome/browser/resources/chromeos/login/oobe_change_picture.js
[modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/chrome/browser/resources/settings/people_page/change_picture.js
[modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js
[modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
[modify] https://crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js

Based on comments and P2 I'm removing RBS

Issue is fixed by CL that landed yesterday, do we want to request a merge? or mark as fixed?

requesting merge. will merge if approved or close if denied.

This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d

commit 5946dbf3fd9d3f924d6e42954ddd32adbe5e691d
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon Nov 27 18:40:06 2017

Focus action button instead of triggering in profile picture chooser.

This improves accessibility behavior by focusing the button that will
perform the action when the selected item is pressed. Before, this
would have deleted a user photo or taken a photo. The new behavior
moves focus to a button that is properly labeled.

Bug:  765104 , 767820 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8b813a9d53c0e5b47579274253c173fc4294404f
Reviewed-on: https://chromium-review.googlesource.com/764594
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#516391}(cherry picked from commit d4e5fdd3f018ead78e22e62d6a5a1943e0014598)
Reviewed-on: https://chromium-review.googlesource.com/791211
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#572}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/chrome/browser/resources/chromeos/login/oobe_change_picture.js
[modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/chrome/browser/resources/settings/people_page/change_picture.js
[modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js
[modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
[modify] https://crrev.com/5946dbf3fd9d3f924d6e42954ddd32adbe5e691d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_pane.js