New issue
Advanced search Search tips

Issue 765099 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Sep 2017
Cc:
pdr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Iframes with layers not painted to drag image

Project Member Reported by msimoni...@opera.com, Sep 14 2017 
Chrome Version: 63.0.3214.0
OS: Win10, possibly others

What steps will reproduce the problem?
(1) Open the attached test.html testcase.
(2) Drag the frame by its border.

What is the expected result?
It is expected that the drag image will show the content of the iframe.

What happens instead?
There is no content on the drag image. This happens only for iframes that use their own layer.
test.html
177 bytes View Download
drag-expected.png
5.4 KB View Download
drag-failing.png
4.0 KB View Download

Comment 1 by f...@opera.com, Sep 14 2017

Labels: OS-Linux OS-Windows
Status: Available (was: Untriaged)

Comment 2 by f...@opera.com, Sep 14 2017

Components: Blink>DataTransfer

Comment 3 by dcheng@chromium.org, Sep 14 2017

Cc: pdr@chromium.org

Comment 4 by f...@opera.com, Sep 14 2017

Owner: f...@opera.com
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2867b7c20908aaf3ff93fc987166422dfa246949

commit 2867b7c20908aaf3ff93fc987166422dfa246949
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Sep 15 19:20:59 2017

Propagate GlobalPaintFlags to EmbeddedContentView::Paint

The global paint flags - like the kGlobalPaintFlattenCompositingLayers
flag - were lost when descending into frames for painting. This would
cause composited layers to not be painted.
Add a GlobalPaintFlags argument to EmbeddedContentView::Paint, and pass
the flags carried by PaintInfo to it, and propagate as needed.

Bug:  765099 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8c824dd12e7caa4c65cfd0bf0c3ab8de69ddfcfb
Reviewed-on: https://chromium-review.googlesource.com/667160
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#502328}
[add] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/LayoutTests/images/drag-image-descendant-iframe-composited-expected.png
[add] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/LayoutTests/images/drag-image-descendant-iframe-composited-expected.txt
[add] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/LayoutTests/images/drag-image-descendant-iframe-composited.html
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.h
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/frame/EmbeddedContentView.h
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/paint/EmbeddedContentPainter.cpp
[modify] https://crrev.com/2867b7c20908aaf3ff93fc987166422dfa246949/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h

Comment 6 by f...@opera.com, Sep 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment