New issue
Advanced search Search tips

Issue 765093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: ----
Type: ----



Sign in to add a comment

browser_side_navigation_browser_tests failing on chromium.mac/Mac10.12 Tests

Project Member Reported by dullweber@chromium.org, Sep 14 2017

Issue description

browser_side_navigation_browser_tests failing on chromium.mac/Mac10.12 Tests

Builders failed on: 
- Mac10.12 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests


DiceBrowserTest.Reauth is flaky on Mac for browser_side_navigation_browser_tests

https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/5239
https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/5253
https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/5260

[ RUN      ] DiceBrowserTest.Reauth
[3678:4099:0913/135358.155384:WARNING:notification_platform_bridge_mac.mm(521)] AlertNotificationService: XPC connection invalidated.
[3678:92931:0913/135358.885326:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.885551:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.885705:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.886180:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.886662:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.887020:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.887769:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /ListAccounts?gpsia=1&source=ChromiumAccountReconcilor,counter:0,load_time_ms:705&json=standard
[3678:775:0913/135358.907930:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.907962:WARNING:account_fetcher_service.cc(298)] Failed to get UserInfo for main_gaia_id
[3678:775:0913/135358.907991:WARNING:profile_downloader.cc(310)] ProfileDownloader: token request using refresh token failed:Invalid credentials.
../../chrome/browser/signin/dice_browsertest.cc:358: Failure
      Expected: signin::IsAccountConsistencyDiceEnabled()
      Which is: true
To be equal to: IsReconcilorBlocked()
      Which is: false
[3678:775:0913/135358.940240:ERROR:account_tracker.cc(278)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.940269:WARNING:account_tracker.cc(216)] Failed to get UserInfo for main_gaia_id
[3678:775:0913/135358.940289:ERROR:account_tracker.cc(278)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.940351:WARNING:account_tracker.cc(216)] Failed to get UserInfo for main_gaia_id
[3678:775:0913/135358.940761:ERROR:account_tracker.cc(278)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.940784:WARNING:account_tracker.cc(216)] Failed to get UserInfo for secondary_gaia_id
[3678:775:0913/135358.940801:ERROR:account_tracker.cc(278)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.940814:WARNING:account_tracker.cc(216)] Failed to get UserInfo for secondary_gaia_id
[3678:775:0913/135358.941151:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.941174:WARNING:account_fetcher_service.cc(298)] Failed to get UserInfo for secondary_gaia_id
[3678:92931:0913/135358.952479:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.953125:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:92931:0913/135358.953262:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /oauth2/v4/token
[3678:775:0913/135358.953550:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.953580:WARNING:account_fetcher_service.cc(298)] Failed to get UserInfo for main_gaia_id
[3678:775:0913/135358.954217:ERROR:account_tracker.cc(278)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.954241:WARNING:account_tracker.cc(216)] Failed to get UserInfo for main_gaia_id
[3678:775:0913/135358.954257:ERROR:account_tracker.cc(278)] OnGetTokenFailure: Invalid credentials.
[3678:775:0913/135358.954270:WARNING:account_tracker.cc(216)] Failed to get UserInfo for main_gaia_id
[3678:92931:0913/135358.980302:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[3678:775:0913/135359.048574:INFO:sync_scheduler_impl.cc(133)] Scheduling next sync for CryptAuth Enrollment:
    Strategy: Aggressive Recovery
    Time Delta: 0 seconds
    Previous Failures: 1
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce648a37190bf6f19fd575f47ff403b131a450d

commit fce648a37190bf6f19fd575f47ff403b131a450d
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Sep 14 08:57:00 2017

Disable DiceBrowserTest.Reauth on Mac

The test has been flaky for browser_side_navigation_browser_tests.

TBR=droger@chromium.org

Bug:  765093 
Change-Id: I16ef9723ee3f21ef08c11ed587f142aa46ff975d
Reviewed-on: https://chromium-review.googlesource.com/666620
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501904}
[modify] https://crrev.com/fce648a37190bf6f19fd575f47ff403b131a450d/chrome/browser/signin/dice_browsertest.cc

Labels: -Sheriff-Chromium
-Sheriff-Chromium as the test is disabled.

Comment 3 by droger@chromium.org, Sep 18 2017

Components: Services>SignIn
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 18 2017

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by dgn@chromium.org, Oct 20 2017

Labels: OS-Windows
Same issue is seen on the CQ, flaking on windows: https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/23098

Comment 6 by droger@chromium.org, Oct 20 2017

Status: Started (was: Available)

Comment 7 by droger@chromium.org, Oct 20 2017

The failure from comment #5 looks different and is more like  bug 775578 .

Comment 8 by droger@chromium.org, Oct 20 2017

After more investigation, I now think that this is indeed the same as  bug 775578 . Not flagging as duplicate yet, but I'll try to re-enable the test on Mac once the fix for 775578 has landed.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3dbe89043efb0d13ecff8b562d5899eadbb04ae

commit d3dbe89043efb0d13ecff8b562d5899eadbb04ae
Author: David Roger <droger@chromium.org>
Date: Fri Oct 20 19:12:06 2017

[Dice] Fix flakiness in DiceBrowserTest

The test now waits for the tokens to be loaded, rather than failing
when they are not loaded.

Bug:  765093 ,  775578 
Change-Id: I8dbbae389dd4a60a420a3a58bd4a5fa6d043c4d0
Reviewed-on: https://chromium-review.googlesource.com/730732
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510513}
[modify] https://crrev.com/d3dbe89043efb0d13ecff8b562d5899eadbb04ae/chrome/browser/signin/dice_browsertest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a98dcd7726db893d79f801e33711880d5c47e63

commit 1a98dcd7726db893d79f801e33711880d5c47e63
Author: David Roger <droger@chromium.org>
Date: Mon Oct 23 12:03:12 2017

Re-enable DiceBrowserTest.Reauth

This CL fixes a race condition between the FakeGaia handler and the
test expectation.
The test now waits until the FakeGaia handler has been called before
testing the token revocation count.

Bug:  765093 
Change-Id: Icbf9382121fb39ddb8cdd034f1caff7165d0ad89
Reviewed-on: https://chromium-review.googlesource.com/732121
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510769}
[modify] https://crrev.com/1a98dcd7726db893d79f801e33711880d5c47e63/chrome/browser/signin/dice_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment