Issue metadata
Sign in to add a comment
|
Fix Language Settings in Desktop |
||||||||||||||||||||||||||||||||||
Issue descriptionTechnical feature description: We want to implement several changes that affect the Language Settings. The goal is to improve the user experience by fixing the main bugs and removing unexpected behavior. Eng owner: claudiomagni@chromium.org Design doc: https://docs.google.com/document/d/1DcJdOPTOZAJYE-c-_qY-HrFl37lC5Rr6gPng3Vt6b-0 Metrics: We will monitor changes of the metrics related to user interacting with Language Settings as well as metrics related to Translate widget (accept/refuse translation)
,
Sep 14 2017
,
Sep 14 2017
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31f0d7fc389035ee8403ecc22759715ee98042de commit 31f0d7fc389035ee8403ecc22759715ee98042de Author: Claudio Magni <claudiomagni@chromium.org> Date: Mon Sep 25 06:52:57 2017 Remove automatic expansion of language list in Settings. This is part of a large change for Language Settings. This CL only fixes the automatic expansion of the language list, which adds the base language whenever a locale-specific one is added. The feature is behind a disabled flag. Bug: 640763 , 765077 Change-Id: Ie7d32c06bef0f933bf1e097a277ac063a9c2b54e Reviewed-on: https://chromium-review.googlesource.com/670459 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#503993} [modify] https://crrev.com/31f0d7fc389035ee8403ecc22759715ee98042de/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/31f0d7fc389035ee8403ecc22759715ee98042de/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/31f0d7fc389035ee8403ecc22759715ee98042de/components/translate/core/browser/translate_prefs_unittest.cc [modify] https://crrev.com/31f0d7fc389035ee8403ecc22759715ee98042de/tools/metrics/histograms/enums.xml
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b800ebb02933977cedb0acde11eb637869bf98e1 commit b800ebb02933977cedb0acde11eb637869bf98e1 Author: Claudio Magni <claudiomagni@chromium.org> Date: Thu Jan 18 02:47:38 2018 Change the new Language Settings flag to default-enabled. Design doc: https://docs.google.com/document/d/1DcJdOPTOZAJYE-c-_qY-HrFl37lC5Rr6gPng3Vt6b-0 Bug: 765077 Change-Id: Ib378858e929d8c29843c7eb4a3a494fdc85ecf58 Reviewed-on: https://chromium-review.googlesource.com/867178 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#530028} [modify] https://crrev.com/b800ebb02933977cedb0acde11eb637869bf98e1/components/translate/core/browser/translate_prefs.cc
,
Jan 29 2018
,
Jan 29 2018
,
Jan 29 2018
This is a fix for a group of bugs/a refactor, no need to treat it as a launch IMO
,
Jan 29 2018
,
Jan 29 2018
,
Mar 7 2018
Reminder to mark this as fixed when the ChromeOS bug is fixed |
|||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||
Comment 1 by claudiomagni@chromium.org
, Sep 14 2017