New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765075 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

“Thats all for now” content suggestion message disappears on force quitting the app.

Project Member Reported by pmadalla@chromium.org, Sep 14 2017

Issue description

App Version: 62.0.3202.21 beta
iOS Version: 10.3.3,11.0
Device : iPhone,iPad

Precondition :
1- Enable content suggestions

Steps to reproduce:

  1. Launch chrome
  2. Remove all the content suggestions.
  3. Force quit the app and relaunch chrome.

Observed results:
“Thats all for now” content suggestion message disappears

Note :Message is displayed on opening a newtab

Expected results:
“Thats all for now” content suggestion message should be displayed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Yes
Bug reproducible on Safari/Firefox: NA
Bug reproducible on current stable build (App Version, iOS Version): No in m61, New change Implementation from 62
Bug reproducible on the current beta channel build (App Version, iOS Version):  Yes in M62

Link to Video :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpbDRHR1VZOTk4MW8/view?usp=sharing

 
Updating :
Bug reproducible on Chrome Mobile on Android: No
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by fi...@chromium.org, Sep 18 2017

Labels: zine-triaged
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7756d365ea5b785ed8ff68a4222c23f7f876bca3

commit 7756d365ea5b785ed8ff68a4222c23f7f876bca3
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Sep 19 12:49:22 2017

Display the empty section if needed

The ContentSuggestions empty sections can be displayed if their section
info allow them to.
For now they are only displayed if they are started at the opening of
the NTP. This CL fixes it by adding them if needed.

Bug:  765075 
Change-Id: Ieb8dde40d14044bfb674bcd9108b84775d1b4531
Reviewed-on: https://chromium-review.googlesource.com/671021
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502833}
[modify] https://crrev.com/7756d365ea5b785ed8ff68a4222c23f7f876bca3/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/7756d365ea5b785ed8ff68a4222c23f7f876bca3/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
That's all for now is displayed after force quitting the app and relaunch.

Verified on M63.0.3237.0 canary, iPhone7 plus, iOS11.1 beta#2.

Sign in to add a comment