New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765074 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Tab crashes after performing audit on second NTP in devtools.

Reported by rp...@etouch.net, Sep 14 2017

Issue description

Version: 61.0.3163.91 2f544949507dc5330b714cb017e3f584e791a1bf-refs/branch-heads/3163@{#1194}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS,Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1.Launch chrome, navigate to NTP and open devtools and run audit and again open new tab and perform same.
2.Now perform step 1 again by closing the open tabs,observe (Refer screen cast)
 
Actual: Tab crashes after performing audit on second NTP
Expected: Tab should not crash

Crash ID : ID 254e25ad0e2e2c02 (Local Crash ID: f3931a8d-ae2b-4d8e-91a6-ce1a8c47fd81)
           ID 06e8ff84a7a0a525 (Local Crash ID: 8f15b8c6-f14d-4224-9816-f7db3b2b6704)

This is regression issue, broken in ‘M 61’ and will soon update other info :
Good build:61.0.3143.0
Bad build: 61.0.3144.0
 
Actual_video.mp4
989 KB View Download
Expected_video.mp4
1.0 MB View Download

Comment 1 by rp...@etouch.net, Sep 14 2017

Labels: hasbisect-per-revision Stability-Crash HasTestcase
Owner: alex...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 61.0.3143.0 (Revision: 482835).
Bad build: 61.0.3144.0 (Revision: 483234).

You are probably looking for a change made after 482878 (known good), but no lat
er than 482879 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/ac4fed459c00385fa0c86a041259f0bad16b029a..13fe1960e0819a5b5e642de1b5b845875601f769?pretty=fuller&n=100

From the CL above, assigning the issue to the concern owner 

@alexmos- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Suspect : https://chromium.googlesource.com/chromium/src/+/13fe1960e0819a5b5e642de1b5b845875601f769

Thanks!
Labels: -M-63 M-61
Cc: pbomm...@chromium.org gov...@chromium.org abdulsyed@chromium.org
Labels: ReleaseBlock-Stable
Crash ID reported on M61 - d86865709160f41a, 79834daf71c3473b

Tagging with Stable blocker, please undo or remove if not the case.

Thanks.!

Comment 4 by gov...@chromium.org, Sep 14 2017

Cc: dgozman@chromium.org
Labels: -M-61 M-62
Owner: phulce@chromium.org
I believe this should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/639032. Patrick, could you please confirm? If so, we should merge to M62.

Comment 6 by phulce@chromium.org, Sep 14 2017

Owner: alex...@chromium.org
@dgozman, that change doesn't actually fix this issue unfortunately as the NTP is just an HTTPS page at google.com with a service worker.

@alexmos is this in any way related to the other recent issue (https://bugs.chromium.org/p/chromium/issues/detail?id=764202)? It seems to be working fine in Canary for me so it might have been some required interaction between your CLs if it is related?

I doubt it's related to  issue 764202 , as the CLs that have caused that all landed after M61 (or M62, for that matter).

I also doubt it's related to my https://chromium.googlesource.com/chromium/src/+/13fe1960e0819a5b5e642de1b5b845875601f769, as that should only affect process reuse behavior when over process limit, whereas this repro shouldn't be over process limit.  But I'll try the problematic build out locally to confirm before unassigning myself.

#6: I thought audits are currently busted in latest canary due to  issue 764519 , so I was quite surprised that it's working for you. :)  They seem to never complete for me on 63.0.3215.0.
Cc: alex...@chromium.org
Owner: alph@chromium.org
One of the crashes points to blink::WindowProxy::SetGlobalProxy(v8::Local<v8::Object>), which is probably a dupe of issue 765101.

All others point to CHECK triggered in content::CPUThrottlingThread::CPUThrottlingThread(double). Over to alph@ for investigation.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/241f91f256d5ee44d140fa9f00333648c3e65cc7

commit 241f91f256d5ee44d140fa9f00333648c3e65cc7
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Sep 20 02:26:20 2017

DevTools: make sure there's a single cpu throttler thread.

BUG= 765074 

Change-Id: Ifde666f07b568d3e87852b10a6cab8fc7372bce8
Reviewed-on: https://chromium-review.googlesource.com/669902
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503029}
[modify] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/content/renderer/devtools/devtools_cpu_throttler.cc
[modify] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/content/renderer/devtools/devtools_cpu_throttler.h
[modify] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[add] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple-expected.txt
[add] https://crrev.com/241f91f256d5ee44d140fa9f00333648c3e65cc7/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple.js

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b4c77f094c17f529233ff29fc89bccdac48a3e

commit f9b4c77f094c17f529233ff29fc89bccdac48a3e
Author: calamity <calamity@chromium.org>
Date: Wed Sep 20 07:35:06 2017

Revert "DevTools: make sure there's a single cpu throttler thread."

This reverts commit 241f91f256d5ee44d140fa9f00333648c3e65cc7.

Reason for revert: Suspecting this CL for failure of
http/tests/devtools/sources/debugger-ui/source-frame-count.html:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/5255

Original change's description:
> DevTools: make sure there's a single cpu throttler thread.
> 
> BUG= 765074 
> 
> Change-Id: Ifde666f07b568d3e87852b10a6cab8fc7372bce8
> Reviewed-on: https://chromium-review.googlesource.com/669902
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503029}

TBR=dgozman@chromium.org,alph@chromium.org

Change-Id: Ibb6efab0e1649e5a22a3861889c6cde96aeb677c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  765074 
Reviewed-on: https://chromium-review.googlesource.com/674789
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503076}
[modify] https://crrev.com/f9b4c77f094c17f529233ff29fc89bccdac48a3e/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/f9b4c77f094c17f529233ff29fc89bccdac48a3e/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/f9b4c77f094c17f529233ff29fc89bccdac48a3e/content/renderer/devtools/devtools_cpu_throttler.cc
[modify] https://crrev.com/f9b4c77f094c17f529233ff29fc89bccdac48a3e/content/renderer/devtools/devtools_cpu_throttler.h
[modify] https://crrev.com/f9b4c77f094c17f529233ff29fc89bccdac48a3e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[delete] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple-expected.txt
[delete] https://crrev.com/6ff1170193fb676372089bbe321287e1db5a1d51/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple.js

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e46a6f685f9b3b28984f14f564aa1591985f8e9

commit 9e46a6f685f9b3b28984f14f564aa1591985f8e9
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Sep 20 19:15:16 2017

Revert "Revert "DevTools: make sure there's a single cpu throttler thread.""

This reverts commit f9b4c77f094c17f529233ff29fc89bccdac48a3e.

Reason for revert:

The original revert was wrong.
1. The patch does not change behavior when CPU throttling is not enabled.
2. The failing test is flaky according to the flakiness dashboard [1].
3. The bot test failure recovered in build #5257 [2] while the revert landed later in #5263 [3].

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger-ui%2Fsource-frame-count.html
[2] https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/5257
[3] https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20(dbg)/builds/5263
Original change's description:
> Revert "DevTools: make sure there's a single cpu throttler thread."
> 
> This reverts commit 241f91f256d5ee44d140fa9f00333648c3e65cc7.
> 
> Reason for revert: Suspecting this CL for failure of
> http/tests/devtools/sources/debugger-ui/source-frame-count.html:
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/5255
> 
> Original change's description:
> > DevTools: make sure there's a single cpu throttler thread.
> > 
> > BUG= 765074 
> > 
> > Change-Id: Ifde666f07b568d3e87852b10a6cab8fc7372bce8
> > Reviewed-on: https://chromium-review.googlesource.com/669902
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#503029}
> 
> TBR=dgozman@chromium.org,alph@chromium.org
> 
> Change-Id: Ibb6efab0e1649e5a22a3861889c6cde96aeb677c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  765074 
> Reviewed-on: https://chromium-review.googlesource.com/674789
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: calamity <calamity@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503076}

TBR=dgozman@chromium.org,calamity@chromium.org,alph@chromium.org

Change-Id: I4acd138ed87ff5ccc7509eab6dd1f6d3851bb781
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  765074 
Reviewed-on: https://chromium-review.googlesource.com/676123
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503225}
[modify] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/content/renderer/devtools/devtools_cpu_throttler.cc
[modify] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/content/renderer/devtools/devtools_cpu_throttler.h
[modify] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[add] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple-expected.txt
[add] https://crrev.com/9e46a6f685f9b3b28984f14f564aa1591985f8e9/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple.js

Comment 12 by alph@chromium.org, Sep 20 2017

Labels: Merge-Request-62
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 21 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can you please comment which fix requires a merge and why? I see some reverts and it's unclear exactly what will be merged. 

Comment 15 by alph@chromium.org, Sep 22 2017

The request is about the following commit https://chromium.googlesource.com/chromium/src/+/241f91f256d5ee44d140fa9f00333648c3e65cc7

I has been unreasonably reverted and then relanded. It fixes a Chrome crash when the user performs audit in DevTools on two pages simultaneously.
 Issue 768212  has been merged into this issue.
Labels: -Merge-Review-62 Merge-Approved-62
Ok great - thanks for the fix. Approving merge to M62. branch:3202
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 28 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a896cf1782ea1c76cfc6f8780f289904669f7373

commit a896cf1782ea1c76cfc6f8780f289904669f7373
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Sep 28 21:33:00 2017

DevTools: make sure there's a single cpu throttler thread.

BUG= 765074 
TBR=alph@chromium.org

(cherry picked from commit 241f91f256d5ee44d140fa9f00333648c3e65cc7)

Change-Id: Ifde666f07b568d3e87852b10a6cab8fc7372bce8
Reviewed-on: https://chromium-review.googlesource.com/669902
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503029}
Reviewed-on: https://chromium-review.googlesource.com/691137
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#494}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/content/renderer/devtools/devtools_cpu_throttler.cc
[modify] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/content/renderer/devtools/devtools_cpu_throttler.h
[modify] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[add] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple-expected.txt
[add] https://crrev.com/a896cf1782ea1c76cfc6f8780f289904669f7373/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-cpu-throttling-multiple.js

Comment 19 by alph@chromium.org, Sep 28 2017

Labels: -merge-merged-3202 Merge-Approved-62
Status: Fixed (was: Assigned)
The second crash cause (SetThrottlingRate) is fixed.

Comment 20 by alph@chromium.org, Sep 28 2017

Labels: -Merge-Approved-62 merge-merged-3202

Sign in to add a comment