Verify all PWA URLs of loading.mobile |
||
Issue descriptionThere are some useless urls in the PWA page set of loading.mobile. (ex. 'Suumo' does not register service worker in the url which currently used for perf test, but does in the top page.) Check all urls, and remove/replace them if it needed. loading_mobile.py: https://cs.chromium.org/chromium/src/tools/perf/page_sets/loading_mobile.py?q=loading_mobile&sq=package:chromium&dr=C&l=84 Design doc of perf benchmark for PWA: https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4767a46679321ccac0ed7657573c4fd6bdc0847c commit 4767a46679321ccac0ed7657573c4fd6bdc0847c Author: Yuki Yamada <yukiy@google.com> Date: Fri Sep 29 08:07:24 2017 Record WPRs for PWAs in loading.mobile After fixed crbug.com/736697 , we have to record PWA's WPR again with new perf benchmarks. Suumo did not registered service worker in previons url, so also Replaced it by top page to check service worker performance before recording wpr-go. Also removed some urls which are not used in loading.mobile . Bug: 765058 Change-Id: Iaf7da788f7a57078ca9475b6283b338f3facb7a3 Reviewed-on: https://chromium-review.googlesource.com/688995 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#505325} [modify] https://crrev.com/4767a46679321ccac0ed7657573c4fd6bdc0847c/tools/perf/page_sets/data/loading_mobile.json [add] https://crrev.com/4767a46679321ccac0ed7657573c4fd6bdc0847c/tools/perf/page_sets/data/loading_mobile_003.wprgo.sha1
,
Oct 2 2017
I think it's finished. Let's close this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by yukiy@google.com
, Sep 28 2017