New issue
Advanced search Search tips

Issue 765039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove code for lock screen apps background state

Project Member Reported by tbarzic@chromium.org, Sep 14 2017

Issue description

UX approach with showing lock screen apps in the lock screen background when the user clicks Unlock button was abandoned in favour of simply closing the app window.

Code for supporting this state should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3da0b4c437c872b3a2e5992b32b09c512a942fc

commit a3da0b4c437c872b3a2e5992b32b09c512a942fc
Author: Toni Barzic <tbarzic@google.com>
Date: Tue Sep 19 20:43:50 2017

Remove backgroud state methods from lock screen apps StateController

Removes the following methods (that became unneeded since background
state is not used anymore):
  * MoveToBackground - use CloseLockScreenNote instead
  * MoveToForeground - no-op unless in background state
  * RecordLockScreenAppUnlockAction - no-op unless in background state

BUG= 765039 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifea8f289b24f96c21dd0675f2fc4cfa0c9d0e49d
Reviewed-on: https://chromium-review.googlesource.com/668236
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502942}
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/chromeos/lock_screen_apps/state_controller.cc
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/chromeos/lock_screen_apps/state_controller.h
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/resources/chromeos/login/header_bar.js
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/resources/chromeos/login/md_header_bar.js
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/a3da0b4c437c872b3a2e5992b32b09c512a942fc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49

commit f5f7a669d0e9c373870fe322e7c62dac1e3a1e49
Author: Toni Barzic <tbarzic@google.com>
Date: Mon Sep 25 21:55:34 2017

Ignore background state in LockActionHandlerLayoutManager

UX with lock screen app windows being shown behind (as a background)
lock screen UI has been abandoned (in favour of simply closing the app
window). This means that TrayActionState::kBackground is now
unreachable, and can be removed.

This CL removed background state handling from
LockActionHandlerLayoutManager, which used to restack app window
over/bellow lock window depending on the current note action state
(now app windows should never be stacked bellow the lock window).

BUG= 765039 

Change-Id: I7cb95e2aa906fb7e8141f5ad7061df8973e10197
Reviewed-on: https://chromium-review.googlesource.com/669953
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504176}
[modify] https://crrev.com/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49/ash/wm/lock_action_handler_layout_manager.cc
[modify] https://crrev.com/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49/ash/wm/lock_action_handler_layout_manager.h
[modify] https://crrev.com/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49/ash/wm/lock_action_handler_layout_manager_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e470c6e228c831c4ca93a26465e7962bf020adc6

commit e470c6e228c831c4ca93a26465e7962bf020adc6
Author: Toni Barzic <tbarzic@google.com>
Date: Sat Sep 30 23:13:32 2017

Allow events in lock action handler container regardless of state

Removes EventClientImpl's restriction on passing events to lock
action handler container only when lock screen note action state is
active.

The purpose of this code was to restrict lock screen note handler app
windows (which were parented by the container) from getting focus
when shown in background (under the lock screen UI). The background
state has been since defunct, and thus the need for restricting the
container from getting events unless a lock screen action is in
active state.

BUG= 765039 

Change-Id: I72da65ac9f2e82aeaaafb3ba0038273c4a53bead
Reviewed-on: https://chromium-review.googlesource.com/687992
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505471}
[modify] https://crrev.com/e470c6e228c831c4ca93a26465e7962bf020adc6/ash/wm/event_client_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment