Remove code for lock screen apps background state |
||
Issue descriptionUX approach with showing lock screen apps in the lock screen background when the user clicks Unlock button was abandoned in favour of simply closing the app window. Code for supporting this state should be removed.
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49 commit f5f7a669d0e9c373870fe322e7c62dac1e3a1e49 Author: Toni Barzic <tbarzic@google.com> Date: Mon Sep 25 21:55:34 2017 Ignore background state in LockActionHandlerLayoutManager UX with lock screen app windows being shown behind (as a background) lock screen UI has been abandoned (in favour of simply closing the app window). This means that TrayActionState::kBackground is now unreachable, and can be removed. This CL removed background state handling from LockActionHandlerLayoutManager, which used to restack app window over/bellow lock window depending on the current note action state (now app windows should never be stacked bellow the lock window). BUG= 765039 Change-Id: I7cb95e2aa906fb7e8141f5ad7061df8973e10197 Reviewed-on: https://chromium-review.googlesource.com/669953 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#504176} [modify] https://crrev.com/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49/ash/wm/lock_action_handler_layout_manager.cc [modify] https://crrev.com/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49/ash/wm/lock_action_handler_layout_manager.h [modify] https://crrev.com/f5f7a669d0e9c373870fe322e7c62dac1e3a1e49/ash/wm/lock_action_handler_layout_manager_unittest.cc
,
Sep 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e470c6e228c831c4ca93a26465e7962bf020adc6 commit e470c6e228c831c4ca93a26465e7962bf020adc6 Author: Toni Barzic <tbarzic@google.com> Date: Sat Sep 30 23:13:32 2017 Allow events in lock action handler container regardless of state Removes EventClientImpl's restriction on passing events to lock action handler container only when lock screen note action state is active. The purpose of this code was to restrict lock screen note handler app windows (which were parented by the container) from getting focus when shown in background (under the lock screen UI). The background state has been since defunct, and thus the need for restricting the container from getting events unless a lock screen action is in active state. BUG= 765039 Change-Id: I72da65ac9f2e82aeaaafb3ba0038273c4a53bead Reviewed-on: https://chromium-review.googlesource.com/687992 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#505471} [modify] https://crrev.com/e470c6e228c831c4ca93a26465e7962bf020adc6/ash/wm/event_client_impl.cc
,
Oct 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/878a90eea19748d2d44fd0530ba3058dd85babc2 commit 878a90eea19748d2d44fd0530ba3058dd85babc2 Author: Toni Barzic <tbarzic@google.com> Date: Wed Oct 18 00:31:09 2017 Remove kBackground state from tray_action interface The state is not used anymore. BUG= 765039 Change-Id: I155134799c87614e4e8d8429b96aeef1f8bdf63a Reviewed-on: https://chromium-review.googlesource.com/693555 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#509625} [modify] https://crrev.com/878a90eea19748d2d44fd0530ba3058dd85babc2/ash/public/interfaces/tray_action.mojom [modify] https://crrev.com/878a90eea19748d2d44fd0530ba3058dd85babc2/ash/shelf/login_shelf_view_unittest.cc [modify] https://crrev.com/878a90eea19748d2d44fd0530ba3058dd85babc2/ash/tray_action/tray_action_unittest.cc [modify] https://crrev.com/878a90eea19748d2d44fd0530ba3058dd85babc2/ash/wm/lock_action_handler_layout_manager.cc [modify] https://crrev.com/878a90eea19748d2d44fd0530ba3058dd85babc2/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc [modify] https://crrev.com/878a90eea19748d2d44fd0530ba3058dd85babc2/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
,
Oct 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 19 2017