New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764994 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 753224



Sign in to add a comment

Cache render surface in screen rotation animation.

Project Member Reported by wutao@chromium.org, Sep 13 2017

Issue description

Cache render surface in screen rotation animation.
 

Comment 1 by wutao@chromium.org, Sep 13 2017

Blocking: 753224

Comment 2 by wutao@chromium.org, Sep 13 2017

Components: Internals>Compositing

Comment 3 by wutao@chromium.org, Sep 20 2017

There are two difficulties to apply render surface in screen rotation animation:

1. There is no need to create render surface in the screen rotation animation. Therefore, create a render surface to cache might be a regression.

2. The animation is implemented by Update opacity and transform from SetYYYYYYFromAnimation. Currently this will invalidate the cache.
https://cs.chromium.org/chromium/src/ash/rotator/screen_rotation_animation.cc?l=52&rcl=3b0c53b9487ec33ae93f8f6c071c64f936d97f06

I and ajuma@ discussed offline about two possible solutions:

1. Maybe a short term solution, modify the screen rotation animation so that we can use cc::Animation, not using SetYYYYYYFromAnimation. ajuma@ pointed out this will not make the animation faster. But we can reuse the cache by this modification because it will not invalidate the render surface cache in current code.

2. For long term solution, to create a better mechanism to identify the damage source, from cc::Animation or UI animation. Any damage from cc::Animation might be ok not to invalidate the cache.
https://bugs.chromium.org/p/chromium/issues/detail?id=755828


Status: Assigned (was: Available)
Status: WontFix (was: Assigned)
We may not want this feature soon. Close for now.

Sign in to add a comment