New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764966 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Play Stable] Copy link text option is gone from long press menu

Project Member Reported by hongchic...@chromium.org, Sep 13 2017

Issue description

Chrome Version: 61.0.3163.81
OS: Android 

What steps will reproduce the problem?

https://listnr.corp.google.com/report/73007689132
https://listnr.corp.google.com/report/72516498469
https://listnr.corp.google.com/report/73029113734
https://listnr.corp.google.com/report/72932659696
https://listnr.corp.google.com/report/72851756890
https://listnr.corp.google.com/report/72843741638
https://listnr.corp.google.com/report/72669328620

What is the expected result?

What happens instead?

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Labels: ReleaseBlock-Stable M-61
Owner: danielpark@chromium.org
Status: Assigned (was: Untriaged)
https://codereview.chromium.org/2942963002/ removed "Copy link text" but per kingston@ this should only have applied to the redesign, in M61 it's gone for everyone.

We should bring this back if we can.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8

commit b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8
Author: Daniel Park <danielpark@chromium.org>
Date: Sat Sep 16 02:37:33 2017

[Custom Context Menu] Restoring Copy Link Text Removal

Reverts the changes in https://codereview.chromium.org/2942963002/.
One test currently fails so it's left out so we can merge this asap.

Bug:  764966 
Change-Id: I30cb67c0633fba87178720347eac6c64e440d37c
Reviewed-on: https://chromium-review.googlesource.com/669761
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502477}
[modify] https://crrev.com/b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
[modify] https://crrev.com/b1e1e775c874eb2a05e8695ecd8e6cc1c36ce5b8/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java

Verified fix in 61.0.3163.96. 
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62acd607eeb44ca7b4ff49e89bb3123947c6c45d

commit 62acd607eeb44ca7b4ff49e89bb3123947c6c45d
Author: Daniel Park <danielpark@chromium.org>
Date: Tue Oct 03 17:22:22 2017

[Custom Context Menu] Restoring Copy Link Text Removal

Reverts the changes in https://codereview.chromium.org/2942963002/.
One test currently fails so it's left out so we can merge this asap.

Bug:  764966 
Change-Id: I30cb67c0633fba87178720347eac6c64e440d37c
Reviewed-on: https://chromium-review.googlesource.com/669959
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/3163@{#1211}
Cr-Original-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}(cherry picked from commit 76c769a30fb816d8f48945995e779bfd8a55d53c)
Reviewed-on: https://chromium-review.googlesource.com/695283
Cr-Commit-Position: refs/branch-heads/3202@{#559}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/62acd607eeb44ca7b4ff49e89bb3123947c6c45d/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/62acd607eeb44ca7b4ff49e89bb3123947c6c45d/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/62acd607eeb44ca7b4ff49e89bb3123947c6c45d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/62acd607eeb44ca7b4ff49e89bb3123947c6c45d/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java

"Copy link text" option is now available in long press menu on any link, verified on latest M62-62.0.3202.45 and M63-63.0.3232.0 checked on Redmi Note 3/MMB29M.
danielpark@, Please mark it as 'Fixed' if there is no other pending CL.
Status: Fixed (was: Assigned)

Sign in to add a comment