New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764965 link

Starred by 1 user
Status: Fixed
Owner:
vakh@chromium.org
Closed: Sep 2017
Cc:
█ awoz@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Replace all hardcoded occurrences of ThreatSource with a call to GetThreatSource()

Project Member Reported by vakh@chromium.org, Sep 13 2017
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f22ffc124d1fbdeb7d420e050ccd55dda2bf95a

commit 2f22ffc124d1fbdeb7d420e050ccd55dda2bf95a
Author: Varun Khaneja <vakh@chromium.org>
Date: Thu Sep 14 01:11:59 2017

Use GetThreatSource instead of hardcoding ThreatSource.

Removes a long time TODO.

Bug:  764965 
Change-Id: I0e1eeb2f4fb824effc73af75ebbd6db0b754a2a1
Reviewed-on: https://chromium-review.googlesource.com/666120
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501822}
[modify] https://crrev.com/2f22ffc124d1fbdeb7d420e050ccd55dda2bf95a/chrome/browser/safe_browsing/download_protection/download_url_sb_client.cc
[modify] https://crrev.com/2f22ffc124d1fbdeb7d420e050ccd55dda2bf95a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2f22ffc124d1fbdeb7d420e050ccd55dda2bf95a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/2f22ffc124d1fbdeb7d420e050ccd55dda2bf95a/components/safe_browsing_db/hit_report.h

Comment 2 by vakh@chromium.org, Sep 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment