Download tray is empty for a malware download |
|||||||||
Issue descriptionChrome Version : 63.0.3213.3 OS Version: OS X 10.12.6 I have "always ask where to download" on. Steps to repro: 1. Open http://testsafebrowsing.appspot.com/ 2. Click on link in "Should show a "malicious" warning, based on URL: link" 3. Asks where to download, select a directory from local machine. Expected behavior: - Warning about malicious file in the download tray. Observed: - Empty download tray. See screenshot. I'll try to repro this problem and post an update. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3213.3 Safari/537.36
,
Sep 13 2017
Can repro it reliably. Haven't restarted browser.
,
Sep 13 2017
,
Sep 13 2017
Thanks for the report Varun. Test team can try a repro and bisect. Adding RBB for tracking purpose.
,
Sep 14 2017
vakh@ thanks for the issue.. Tried this issue as mentioned in comment #1 on Mac OS 10.12.6 using the latest Canary 63.0.3215.0 and latest Dev 63.0.3213.3. Able to reproduce this issue on latest Canary, but on equivalent signed/unsigned Dev builds, able to download the file with 'test' as the file name and with no warning about the malicious file. Tried this issue on 50.0.2640.0 Dev build on Mac OS 10.12.6 and could see the same behavior like filename as test and no warning message. Note: Issue is not observed on Windows 7 and Ubuntu 14.04 using the latest Canary and stable builds. Attached are the screen shots for reference. Marking this as Untriaged on Mac OS 10.12.6, reproducible on the latest canary and removing the Needs-Bisect label as Issue is not repro on equivalent signed/unsigned builds. Thanks
,
Sep 15 2017
[mac bug traige] sdy@ - can you take a look?
,
Sep 18 2017
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 18 2017
,
Sep 18 2017
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06b94b479ce51fe17ff5913be51df6901beda8f4 commit 06b94b479ce51fe17ff5913be51df6901beda8f4 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Sep 18 17:32:56 2017 Use a more forgiving calculation to hide downloads that overflow the bar. There have been a few bugs with downloads getting incorrectly hidden by this code, usually because they're slightly taller than the bar. Those are technically bugs, but when it affects the old shelf, the right answer is probably just to only look at x position. Bug: 764944 Change-Id: I7fb36dd4cefcfd728ff05bed5e0287daab2d5107 Reviewed-on: https://chromium-review.googlesource.com/671291 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#502604} [modify] https://crrev.com/06b94b479ce51fe17ff5913be51df6901beda8f4/chrome/browser/ui/cocoa/download/download_item_controller.mm
,
Sep 18 2017
,
Sep 19 2017
Verified this issue on Mac OS 10.12.6 using chrome latest canary 63.0.3219.0 by following steps mentioned in the original comment. Observed that when a malicious file is downloaded, a warning message is seen on the download tray. Hence adding TE-Verified label for M-63. Thanks.. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vakh@chromium.org
, Sep 13 2017