MD Extensions: needs to implement kiosk app management page. |
||||||||||||||||||
Issue descriptionThis is a feature in the old UI for managing kiosk apps. To get it working on a linux dev box: 1. locally patch this (but do not commit): https://chromium-review.git.corp.google.com/c/chromium/src/+/668085 2. run chromeOS on linux, add "--enable-consumer-kiosk". 3. Login with as non-guest user 4. Goto chrome://extensions 5. Select Developer Mode checkbox Attached is screenshots of the old UI. Things we want to support in the UI: Add a kiosk app, remove a kiosk app, set/unset auto launch (only one app can be auto launched), whether to allow ctrl+alt+s bail out during launch. - Note that the autolaunch capability can be disabled for the device. See: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc?type=cs&q=enableKiosk&l=234
,
Sep 13 2017
talked a bit with xiyuan@, there are still users of this feature doing regular updates, who we'll have to support for a few years until device EOL. So confirmed we'll have to port it over to MD Extensions.
,
Sep 13 2017
and here's the code from the old UI: https://cs.chromium.org/chromium/src/chrome/browser/resources/extensions/chromeos/?q=chromeos/kiosk&sq=package:chromium
,
Sep 14 2017
+sduraisamy fyi Think we still have to support consumer kiosk since there are still devices out there with the feature. It might take a couple of years before they all go to end of life. Note this is a chromeos only UI and is available only to the owner of the device (i.e. first signed-in user on a consumer chromeos device).
,
Sep 14 2017
,
Sep 15 2017
,
Sep 15 2017
,
Sep 15 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2083075aa59988559cf3caee156e285586e997ae commit 2083075aa59988559cf3caee156e285586e997ae Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 27 19:05:14 2017 Extensions: modernize kiosk app handler code. To allow new WebUI to use the KioskAppsHandler code, this CL converts all the CallJavascriptUnsafe calls to either fire a WebUI event, or resolve a specific Javascript promise. Bug: 764943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I04e0f81220251cfd3eaab3100b256f13b7f34430 Reviewed-on: https://chromium-review.googlesource.com/676092 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#504746} [modify] https://crrev.com/2083075aa59988559cf3caee156e285586e997ae/chrome/browser/resources/extensions/chromeos/kiosk_apps.js [modify] https://crrev.com/2083075aa59988559cf3caee156e285586e997ae/chrome/browser/resources/extensions/compiled_resources2.gyp [modify] https://crrev.com/2083075aa59988559cf3caee156e285586e997ae/chrome/browser/resources/extensions/extensions.html [modify] https://crrev.com/2083075aa59988559cf3caee156e285586e997ae/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js [modify] https://crrev.com/2083075aa59988559cf3caee156e285586e997ae/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc [modify] https://crrev.com/2083075aa59988559cf3caee156e285586e997ae/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h
,
Sep 27 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939 commit 3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939 Author: Scott Chen <scottchen@chromium.org> Date: Thu Sep 28 19:44:40 2017 MD Extensions: port over consumer kiosk management dialog. This CL ports over the kiosk app management modal from the existing extensions page to the MD extensions page. Bug: 764943 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib35d989227aa023dc08673fb54d8f38275abad80 Reviewed-on: https://chromium-review.googlesource.com/671905 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#505122} [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/app/md_extensions_strings.grdp [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/browser_resources.grd [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/compiled_resources2.gyp [add] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/kiosk_browser_proxy.html [add] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/kiosk_browser_proxy.js [add] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/kiosk_dialog.html [add] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/kiosk_dialog.js [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/toolbar.html [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/resources/md_extensions/toolbar.js [modify] https://crrev.com/3a5d08dc3d4bdd03cbac40b1c8a52d1b7eec2939/chrome/browser/ui/webui/extensions/extensions_ui.cc
,
Sep 28 2017
This is now landed on ToT. Xiyuan@ do you if we could get this in front of QA who's familiar with the kiosk management tool to try and break it?
,
Jan 22 2018
,
Jan 23 2018
,
Mar 10 2018
verified fixed
,
Mar 10 2018
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by scottchen@chromium.org
, Sep 13 2017