[MD settings] font size too small on autofill settings on mac osx |
||||||||
Issue descriptionin chrome://settings in the advanced area, there is a row for the password autofill settings. The font size on the label is 11px on OSX only. OSX overrides the default font size for buttons and I recently changed that row to be a button.
,
Sep 13 2017
@dschuyler: Is this the same root cause for issue 764608 ? If so let's merge them.
,
Sep 13 2017
Issue 764608 has been merged into this issue.
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49684282e5a1536d55af2ba4934931eaf6c59272 commit 49684282e5a1536d55af2ba4934931eaf6c59272 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Sep 14 02:54:11 2017 [cr webui] set font size on cr-link-row This CL sets the font size to 100% on a link row. This addresses two issues: - The overridden Mac specific size of 11px is set back to the MD settings default of 13px. - On desktop (mac and non-mac) the font size will follow the custom font size selected by the user. Bug: 764942 , 764608 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice9404cea6c1303f60e96babd72c354f85596594 Reviewed-on: https://chromium-review.googlesource.com/666219 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501852} [modify] https://crrev.com/49684282e5a1536d55af2ba4934931eaf6c59272/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
,
Sep 14 2017
,
Sep 15 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 15 2017
Approving merge to M62. Branch:3202
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5384a06769acea83ddb7dd38b85888fceaecf7f6 commit 5384a06769acea83ddb7dd38b85888fceaecf7f6 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Sep 15 20:52:08 2017 [cr webui] set font size on cr-link-row This CL sets the font size to 100% on a link row. This addresses two issues: - The overridden Mac specific size of 11px is set back to the MD settings default of 13px. - On desktop (mac and non-mac) the font size will follow the custom font size selected by the user. Bug: 764942 , 764608 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice9404cea6c1303f60e96babd72c354f85596594 Reviewed-on: https://chromium-review.googlesource.com/666219 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501852}(cherry picked from commit 49684282e5a1536d55af2ba4934931eaf6c59272) Reviewed-on: https://chromium-review.googlesource.com/669619 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#263} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/5384a06769acea83ddb7dd38b85888fceaecf7f6/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
,
Sep 15 2017
,
Sep 20 2017
Verified this issue on Mac OS 10.12.6 using chrome latest M62-62.0.3202.79 and observed able to change the size of the font as expected for 'autofill settings' and 'customise fonts' under chrome://settings. Hence adding TE-Verified label. Thanks! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dschuyler@chromium.org
, Sep 13 2017