Apps sometimes don't appear on top |
||||||||||||||||
Issue descriptionLauncher should always display apps on top, looking at Vadim's image today we saw that apps were appearing on the bottom of the list. Vadim, can you triage please.
,
Sep 14 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14 2017
Approving merge to m61 and M62.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19feffb67873127adc3c57701dd042fef9893987 commit 19feffb67873127adc3c57701dd042fef9893987 Author: Weidong Guo <weidongg@chromium.org> Date: Fri Sep 15 01:06:48 2017 cros: Make search results in fixed order for fullscreen app list Reason: The order is incorrect when all the apps in search results are from play store, because its boost is 0.0, which is different from other apps' boost 5.0. Changes: Change play store apps' boost to 5.0 from 0.0. BUG= 764937 Change-Id: I977ec886380aff859b8c84f0ce0f196d29f163fd Reviewed-on: https://chromium-review.googlesource.com/666068 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#502119} [modify] https://crrev.com/19feffb67873127adc3c57701dd042fef9893987/chrome/browser/ui/app_list/search/search_controller_factory.cc
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/897dab8b391292a5472dc1d1562055321357893c commit 897dab8b391292a5472dc1d1562055321357893c Author: Vadim Tryshev <vadimt@google.com> Date: Fri Sep 15 02:01:25 2017 cros: Make search results in fixed order for fullscreen app list Reason: The order is incorrect when all the apps in search results are from play store, because its boost is 0.0, which is different from other apps' boost 5.0. Changes: Change play store apps' boost to 5.0 from 0.0. BUG= 764937 TBR=weidongg@chromium.org (cherry picked from commit 19feffb67873127adc3c57701dd042fef9893987) Change-Id: I977ec886380aff859b8c84f0ce0f196d29f163fd Reviewed-on: https://chromium-review.googlesource.com/666068 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502119} Reviewed-on: https://chromium-review.googlesource.com/668200 Cr-Commit-Position: refs/branch-heads/3163@{#1204} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/897dab8b391292a5472dc1d1562055321357893c/chrome/browser/ui/app_list/search/search_controller_factory.cc
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46025a9cb7f840cd976b130b42ca307fbb549657 commit 46025a9cb7f840cd976b130b42ca307fbb549657 Author: Vadim Tryshev <vadimt@google.com> Date: Fri Sep 15 02:03:45 2017 cros: Make search results in fixed order for fullscreen app list Reason: The order is incorrect when all the apps in search results are from play store, because its boost is 0.0, which is different from other apps' boost 5.0. Changes: Change play store apps' boost to 5.0 from 0.0. BUG= 764937 TBR=weidongg@chromium.org (cherry picked from commit 19feffb67873127adc3c57701dd042fef9893987) Change-Id: I977ec886380aff859b8c84f0ce0f196d29f163fd Reviewed-on: https://chromium-review.googlesource.com/666068 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502119} Reviewed-on: https://chromium-review.googlesource.com/667005 Cr-Commit-Position: refs/branch-heads/3202@{#243} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/46025a9cb7f840cd976b130b42ca307fbb549657/chrome/browser/ui/app_list/search/search_controller_factory.cc
,
Sep 15 2017
,
Oct 7 2017
,
Oct 7 2017
Weidong, could you fix in M62 the following thing: if answer card is present it should go below app results (any combination of installed, Web or playstore results)? So: 1. App results 2. Answer card 3. The rest (unchanged)
,
Oct 7 2017
,
Oct 7 2017
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de74a012d17aaac84b3f1334a6a802b309b27ac5 commit de74a012d17aaac84b3f1334a6a802b309b27ac5 Author: Weidong Guo <weidongg@chromium.org> Date: Mon Oct 09 17:23:41 2017 cros: Make apps always on top in search results for fullscreen app list Changes: Change apps search result's boost to 10.0 and change answer card's boost 5.0 to make sure apps always on top. BUG= 764937 Change-Id: I553e7a769e6937368f218d1cb85cdddb79bf53b8 Reviewed-on: https://chromium-review.googlesource.com/706238 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#507398} [modify] https://crrev.com/de74a012d17aaac84b3f1334a6a802b309b27ac5/chrome/browser/ui/app_list/search/search_controller_factory.cc
,
Oct 9 2017
Request merge into M62 for CL in #13
,
Oct 9 2017
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9 2017
Approved for 62.
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01840e4252afa1e53a5e5200779e7ceec438baa1 commit 01840e4252afa1e53a5e5200779e7ceec438baa1 Author: Weidong Guo <weidongg@chromium.org> Date: Mon Oct 09 21:48:08 2017 cros: Make apps always on top in search results for fullscreen app list Changes: Change apps search result's boost to 10.0 and change answer card's boost 5.0 to make sure apps always on top. BUG= 764937 TBR=xiyuan@chromium.org (cherry picked from commit de74a012d17aaac84b3f1334a6a802b309b27ac5) Change-Id: I553e7a769e6937368f218d1cb85cdddb79bf53b8 Reviewed-on: https://chromium-review.googlesource.com/706238 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#507398} Reviewed-on: https://chromium-review.googlesource.com/707738 Cr-Commit-Position: refs/branch-heads/3202@{#625} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/01840e4252afa1e53a5e5200779e7ceec438baa1/chrome/browser/ui/app_list/search/search_controller_factory.cc
,
Oct 28 2017
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by vadimt@chromium.org
, Sep 14 2017Labels: -Pri-3 M-62 M-61 Merge-Request-61 Merge-Request-62 Pri-1
Owner: weidongg@chromium.org
Status: Assigned (was: Untriaged)