New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764933 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Create EXCLUSIVE_ test prefix that ensures these test cases are run serially

Project Member Reported by mar...@chromium.org, Sep 13 2017

Issue description

The sole purpose of interactive_ui_tests is to run tests single threaded. Otherwise they could as well be part of browser_tests.

The fact this is two separate executable causes these side effects:
- Longer build time due to additional large executable.
- Longer archival time due to more binaries to archive.
- Obscurity from developers. Many people don't even know why interactive_ui_tests exist.
- One-off solution that doesn't scale to other tests (sbox).
- Irrelevant on linux.
- Slightly more complex BUILD.gn file.
- More complex source file tree, as interactive ui tests must be in separate source files from browser_tests.

Proposal:
- Create a prefix (EXCLUSIVE_ or something else) that signals test launcher that the test case needs to be run serially at the start of the test shard, then run all parallel tests together. The prefix needs to be obvious enough so a new developer can guess correctly.
- Move all test cases in interactive_ui_tests back into browser_tests and rename them with the prefix.
- Stop running interactive_ui_tests.
- Stop building interactive_ui_tests.
- Calculate the savings.
 
Cc: baxley@chromium.org jbudorick@chromium.org
+baxley ... this seems like a fine task for your team, should we choose to accept it :).

Comment 2 by jam@chromium.org, Sep 13 2017

one comment that I mentioned to Marc-Antoine: browser_tests is already very hard to debug in Visual Studio because of the large binary/symbol size. It often OOMs. Adding more tests to it, without finding other ways of making it smaller, will make this worse.

Sign in to add a comment