Reading list bottom actions bar overlaps with bottom bar on iPhoneX |
||||||
Issue descriptionApp Version: 63.0.3215.0 iOS Version: iOS11 Device: iPhoneX Sim URL: NTP Steps to reproduce: 1. Launch app 2. Open new tab and navigate to a webpage, add it to the reading list 3. Open Reading list Observed results: Notice the bottom bar with Edit overlaps with the bottom bar in iPhoneX. If you tap Edit more actions are exposed and while Mark all is above the bottom bar, the placement and spacing of these options could be better. Expected results: Bottom bar should fit nicely with the bottom bar on iPhoneX Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_d1FpeDkxampLQzQ/view
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b79a4148712592f2c5bf9e6837d2e8987e02e5f commit 1b79a4148712592f2c5bf9e6837d2e8987e02e5f Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 18 07:36:44 2017 Fix ReadingList toolbar on iPhone X On iPhone X, the safe area is cutting the bottom and sides of the device. The bottom toolbar needs to take it into account to be correctly displayed on iPhone X. Bug: 764917 Change-Id: I71a839d77e8fdbd273e5fca6daee99c0800d5395 Reviewed-on: https://chromium-review.googlesource.com/668536 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#502537} [modify] https://crrev.com/1b79a4148712592f2c5bf9e6837d2e8987e02e5f/ios/chrome/browser/ui/reading_list/reading_list_toolbar.h [modify] https://crrev.com/1b79a4148712592f2c5bf9e6837d2e8987e02e5f/ios/chrome/browser/ui/reading_list/reading_list_toolbar.mm [modify] https://crrev.com/1b79a4148712592f2c5bf9e6837d2e8987e02e5f/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
,
Sep 18 2017
The behavior should be the same on the current devices. On iPhone X, it should respect the safe area. Asking for merge, as this is needed in M62.
,
Sep 18 2017
This bug requires manual review: Less than 25 days to go before AppStore submit on M62 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19 2017
Looks good on iPhoneX simulator. M62.0.3219.0 Chromium Device: iPhoneX Simulator. iOS: 11.0 Screenshots: https://drive.google.com/file/d/0B-xmXLQhjeKucFdmcEllQTRVeFE/view (Landscape) https://drive.google.com/file/d/0B-xmXLQhjeKudWRIaW1GMGMtUG8/view (Portrait)
,
Sep 19 2017
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/717cd2e5826b8716cf264c12825c276a632eb97f commit 717cd2e5826b8716cf264c12825c276a632eb97f Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 20 07:04:23 2017 Fix ReadingList toolbar on iPhone X On iPhone X, the safe area is cutting the bottom and sides of the device. The bottom toolbar needs to take it into account to be correctly displayed on iPhone X. Bug: 764917 Change-Id: I71a839d77e8fdbd273e5fca6daee99c0800d5395 Reviewed-on: https://chromium-review.googlesource.com/668536 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#502537}(cherry picked from commit 1b79a4148712592f2c5bf9e6837d2e8987e02e5f) Reviewed-on: https://chromium-review.googlesource.com/674903 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#350} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/717cd2e5826b8716cf264c12825c276a632eb97f/ios/chrome/browser/ui/reading_list/reading_list_toolbar.h [modify] https://crrev.com/717cd2e5826b8716cf264c12825c276a632eb97f/ios/chrome/browser/ui/reading_list/reading_list_toolbar.mm [modify] https://crrev.com/717cd2e5826b8716cf264c12825c276a632eb97f/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by stkhapugin@chromium.org
, Sep 15 2017Status: Assigned (was: Untriaged)