New issue
Advanced search Search tips

Issue 764870 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-09-13
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

arc: accessibility locations are incorrect

Project Member Reported by dtseng@chromium.org, Sep 13 2017

Issue description

- on a device, enable ChromeVox
- with chromevox-arc-support on, (chrome://flags)
- navigate (search+right) through an ARC++ app

result: orange highlight is off of what ChromeVox is reading i.e. the locations provided for the node are wrong
 

Comment 1 by dtseng@chromium.org, Sep 13 2017

Labels: -arc-aa1y arc-a11y

Comment 2 by yawano@chromium.org, Sep 14 2017

Cc: yawano@chromium.org
Owner: dtseng@chromium.org
Assigning this to dtseng@ as https://crrev.com/c/666079

Comment 3 by dtseng@chromium.org, Sep 14 2017

Owner: yawano@chromium.org
Actually, would you mind taking this one? I was hoping the cl would just work the code was taken from arc voice interaction service), but it looks like that's not sufficient. I'll abandon that change.

Comment 4 by dtseng@chromium.org, Sep 14 2017

Labels: -Pri-3 Pri-1

Comment 5 by yawano@chromium.org, Sep 15 2017

Cc: dtseng@chromium.org
Labels: OS-Chrome
Yes, I'll take this. Thank you.

Comment 6 by yawano@chromium.org, Sep 19 2017

Uploaded a patch set at https://crrev.com/c/671168

Even with the patch set, accessibility location is not shown correctly for popup menu. In Android, popup menu has its own window. But we are not creating a window for it in Chrome.

I'll fix this in Android side to do additional offset for its parent window.

Comment 7 by yawano@chromium.org, Sep 19 2017

I was confused. The CL should work if cause is the my assumption as we are offsetting in Chrome with its parent window. But the reality is that it's not working. I'll try to figure out why the CL is not working for popup menu first.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8d378a2d15a3f9e3bc3b2f4c941b38a8aa34eb

commit 9b8d378a2d15a3f9e3bc3b2f4c941b38a8aa34eb
Author: Yuki Awano <yawano@chromium.org>
Date: Fri Sep 29 03:38:16 2017

Fix accessibility location

- Fix GetBounds to return bounds which can be passed to
  AXNodeData.location. Bounds are returned in the following coordinates.
- Bounds of root node are relative to its container, i.e. focused
  window.
- Bounds of non-root node are relative to its tree's root.
- Bounds are returned in non-dip value.

      Android window with ChromeVox. Confirm that focus rectangle is
      shown on right location.

Bug:  764870 
Test: enable --enable-chromevox-arc-support and navigate elements on
Change-Id: I052c3da643cd3e017b6256372221a6947410da65
Reviewed-on: https://chromium-review.googlesource.com/671168
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505284}
[modify] https://crrev.com/9b8d378a2d15a3f9e3bc3b2f4c941b38a8aa34eb/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/9b8d378a2d15a3f9e3bc3b2f4c941b38a8aa34eb/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h

Status: Started (was: Assigned)
Accessibility location of Android notification is incorrect even after the CL. I'm currently working on it.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f58d42852519bd539a01a868fbea72d9729ec76

commit 5f58d42852519bd539a01a868fbea72d9729ec76
Author: Yuki Awano <yawano@chromium.org>
Date: Fri Oct 13 06:52:42 2017

Translate ax location of Android notification

      notification. Confirm that ax location is correct.

Bug:  764870 
Test: Enable spoken feedback and navigate over elements in Android
Change-Id: I12b75da2c53255faca62ef6c7912e59970c29d86
Reviewed-on: https://chromium-review.googlesource.com/708116
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508626}
[modify] https://crrev.com/5f58d42852519bd539a01a868fbea72d9729ec76/ui/arc/notification/arc_notification_content_view.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc819f6f2f7a404513bf92e447f75aaa174c1c9a

commit cc819f6f2f7a404513bf92e447f75aaa174c1c9a
Author: Yuki Awano <yawano@chromium.org>
Date: Mon Oct 23 10:52:44 2017

Do not offset notification accessibility location

- focused_window is focused application window. No need to offset
  accessibility location of notification by it.
- No need to translate accessibility location of notification without
  the offset.

      Android notification is correct. Especially, confirm that
      accessibility location of popup notification is correct.

Bug:  764870 
Change-Id: I1290e677c9a9c5daac6b41d60fbcfe83c3e83794
Test: Enable spoken feedback and confirm that accessibility location of
Reviewed-on: https://chromium-review.googlesource.com/720726
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510761}
[modify] https://crrev.com/cc819f6f2f7a404513bf92e447f75aaa174c1c9a/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/cc819f6f2f7a404513bf92e447f75aaa174c1c9a/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h
[modify] https://crrev.com/cc819f6f2f7a404513bf92e447f75aaa174c1c9a/ui/arc/notification/arc_notification_content_view.cc

Labels: Merge-Request-63
Request merge a CL in comment 11 (https://crrev.com/c/720726) to M63.
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 24 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 25 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3de443b40c29654b97953f9447d40d12e6397f22

commit 3de443b40c29654b97953f9447d40d12e6397f22
Author: Yuki Awano <yawano@chromium.org>
Date: Wed Oct 25 04:08:24 2017

Do not offset notification accessibility location

- focused_window is focused application window. No need to offset
  accessibility location of notification by it.
- No need to translate accessibility location of notification without
  the offset.

      Android notification is correct. Especially, confirm that
      accessibility location of popup notification is correct.

Bug:  764870 
Change-Id: I1290e677c9a9c5daac6b41d60fbcfe83c3e83794
Test: Enable spoken feedback and confirm that accessibility location of
Reviewed-on: https://chromium-review.googlesource.com/720726
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510761}(cherry picked from commit cc819f6f2f7a404513bf92e447f75aaa174c1c9a)
Reviewed-on: https://chromium-review.googlesource.com/737389
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#208}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/3de443b40c29654b97953f9447d40d12e6397f22/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/3de443b40c29654b97953f9447d40d12e6397f22/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.h

Status: fixed (was: Started)
I believe this one is fixed; please re-open if not.

Sign in to add a comment