Omnibox autosuggest is cut off on the left when in landscape mode on iPhoneX |
||||||
Issue descriptionApp Version: 63.0.3215.0 iOS Version: iOS11 Device: iPhoneX Sim URL: NTP Steps to reproduce: 1. Launch app 2. Open new tab 3. Place cursor in search field and start typing 4. Turn phone to landscape mode Observed results: Observe the left side of the autosuggestions are cut off by the camera and sensor shelf. Expected results: Autosuggest should pad right to account for camera and sensor shelf. Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_TjRxX0RDYld0X0E/view
,
Sep 20 2017
Landscape usability. M63. This is very noticeable and affects usability (can't see text), thus RBS.
,
Sep 21 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d5c70623b5b95fcf5d81d651a0d249d91c4dbe4 commit 3d5c70623b5b95fcf5d81d651a0d249d91c4dbe4 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Sep 22 11:38:00 2017 Fix the omnibox popup on the iPhone X. Starts using the UITableViewCell's content view in the popup rows. On iOS 11, enables UITableView's automatic safe area handling. Bug: 764866 Change-Id: Iab24a6199fa9ce188cad5e42d49e465b8e24192e Reviewed-on: https://chromium-review.googlesource.com/677445 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#503712} [modify] https://crrev.com/3d5c70623b5b95fcf5d81d651a0d249d91c4dbe4/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm [modify] https://crrev.com/3d5c70623b5b95fcf5d81d651a0d249d91c4dbe4/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
,
Sep 22 2017
,
Oct 26 2017
Safe Area handling for omnibox suggestions looking good but the omnibox itself disappeared completely when reproducing this issue. Follow the same steps to repro from comment#0 Observed result: Omnibox is not displayed correctly. Expected result: Omnibox should be displayed correctly above the omnibox suggestions. https://drive.google.com/file/d/1W8edazGRF9Yc5UB8r1VO6l_nXZdVNZj6/view Verified on iPhoneX Simulator M64.0.3251.0 canary, M63.0.3239.19 beta
,
Oct 31 2017
stkhapugin@ what is the status on this RBS?
,
Oct 31 2017
So this only is reproducible with the slim toolbar flag that is not going to be enabled on M63, hence I'm changing this to M64. Also, since the original issue is closed, and there's crbug.com/768374 that basically is the same as Comment#6, I'm closing this again - this time as a dupe of issue 768374. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by stkhapugin@chromium.org
, Sep 15 2017Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)