Keyboard toolbar overlaps bottom bar on iPhone X when cursor is in omnibox |
||||||||
Issue descriptionApp Version: 63.0.3215.0 iOS Version: iOS11 Device: iPhoneX Sim URL: NTP Steps to reproduce: 1. Launch app 2. Open new tab 3. Place cursor in search field Observed results: Observe the bottom of the screen, the toolbar is overlapping the iPhone X bottom bar. Expected results: No overlap should occur. Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_LWF4aV9sUXpfYWs/view
,
Sep 15 2017
This only occurs with users that have a physical keyboard, on iPhone X. That's not going to impact a lot of users, so not high priority. Still would be nice to fix.
,
Sep 20 2017
Moving down the Pri-2. Unlikely that users have Bluetooth keyboards with their phones. What about other apps w/ keyboard accessories do? Is the accessory bar shifted up to be just inside the safe zone?
,
Sep 20 2017
Safari does not, but that does not mean it's not also a bug on their part.
,
Sep 20 2017
,
Sep 20 2017
,
Oct 19 2017
Hey jif@ are you looking into this issue?
,
Oct 20 2017
No. Reason is in comment #2.
,
Oct 24 2017
Quickly looked at how to fix this. The trick is to do "self.allowsSelfSizing = YES;". That's not enough, but I think that it's required.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3e858120c7eb7615b8b0b7e5b60cc61fa00bc07 commit b3e858120c7eb7615b8b0b7e5b60cc61fa00bc07 Author: Elodie Banel <lod@google.com> Date: Thu Nov 09 13:26:36 2017 Align keyboard toolbar to safe area layout guides. Bug: 764857 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I72bb9d508ac24899383bbf22cb0a1bf72ded239d Reviewed-on: https://chromium-review.googlesource.com/757108 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#515156} [modify] https://crrev.com/b3e858120c7eb7615b8b0b7e5b60cc61fa00bc07/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
,
Nov 9 2017
,
Nov 13 2017
Verified on iPhone X iOS 11.1 on build 63.0.3239.48 in Portrait mode. https://drive.google.com/a/google.com/file/d/1vb9WRkjTIeKsHFi4LJkkipMAnC6CttIz/view?usp=sharing In landscape mode it still exists . So going to file new bug for that. Thanks
,
Nov 16 2017
To clarify, this fix landed after branch point so it is not in 63. I will change it for m64 (as it's a bit late for a pri3 bug to be merged to 63 at this point). Please let me know if you are still seeing issues in landscape or portrait at this point, I am not seeing any locally.
,
Nov 16 2017
,
Nov 16 2017
Verified on M64.0.3269.0 Canary. Its stillrepor'ed on iPhone 6+ iOS 11.2 in portrait mode and landscape mode. https://drive.google.com/a/google.com/file/d/1Ff4eQo_sqjZb2eY8krVjKENCjsn7n7kw/view?usp=sharing
,
Nov 16 2017
This bug is about obscuring the iPhone X home screen indicator, not the NTP bottom bar. It's expected that the keyboard and it's accessory views will obscure UI when it slides up. Just not system UI like the home screen indicator. I think you are verifying the wrong thing...
,
Nov 16 2017
Sorry for all the above comments. I verified this bug on a diff understanding . After talking to @justincohen, below is the correct verification: https://drive.google.com/a/google.com/file/d/1sNC-EdSCwVU_1ZNV_VJzqN560CTVzfJb/view?usp=sharing Verified on iPhone X iOS 11.1 in M64.0.3269.0 Canary both in portrait and landscape mode. The iPhone X home screen indicator is no longer obscured by the keyboard accessory.
,
Nov 17 2017
Thanks vbhatsoori & justin for getting this cleared up :) |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by stkhapugin@chromium.org
, Sep 15 2017Owner: jif@chromium.org
Status: Assigned (was: Untriaged)