New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764857 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Keyboard toolbar overlaps bottom bar on iPhone X when cursor is in omnibox

Project Member Reported by linds...@chromium.org, Sep 13 2017

Issue description


App Version: 63.0.3215.0
iOS Version: iOS11
Device: iPhoneX Sim
URL: NTP 

Steps to reproduce:
  1. Launch app
  2. Open new tab
  3. Place cursor in search field

Observed results:
Observe the bottom of the screen, the toolbar is overlapping the iPhone X bottom bar.

Expected results:
No overlap should occur.

Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_LWF4aV9sUXpfYWs/view
 
Components: UI>Input>VirtualKeyboard
Owner: jif@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jif@chromium.org, Sep 15 2017

This only occurs with users that have a physical keyboard, on iPhone X.
That's not going to impact a lot of users, so not high priority.

Still would be nice to fix.

Comment 3 by pkl@chromium.org, Sep 20 2017

Labels: -Pri-1 Pri-2
Moving down the Pri-2.

Unlikely that users have Bluetooth keyboards with their phones.
What about other apps w/ keyboard accessories do? Is the accessory bar shifted up to be just inside the safe zone?

Comment 4 by jif@chromium.org, Sep 20 2017

Safari does not, but that does not mean it's not also a bug on their part.

Screen Shot 2017-09-20 at 16.33.03.png
97.5 KB View Download

Comment 5 by pkl@chromium.org, Sep 20 2017

Labels: M-63

Comment 6 by pkl@chromium.org, Sep 20 2017

Labels: -Pri-2 Pri-3

Comment 7 by cma...@chromium.org, Oct 19 2017

Hey jif@ are you looking into this issue?

Comment 8 by jif@chromium.org, Oct 20 2017

No. Reason is in comment #2.

Comment 9 by jif@chromium.org, Oct 24 2017

Owner: lod@chromium.org
Quickly looked at how to fix this.
The trick is to do "self.allowsSelfSizing = YES;".
That's not enough, but I think that it's required.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e858120c7eb7615b8b0b7e5b60cc61fa00bc07

commit b3e858120c7eb7615b8b0b7e5b60cc61fa00bc07
Author: Elodie Banel <lod@google.com>
Date: Thu Nov 09 13:26:36 2017

Align keyboard toolbar to safe area layout guides.

Bug:  764857 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I72bb9d508ac24899383bbf22cb0a1bf72ded239d
Reviewed-on: https://chromium-review.googlesource.com/757108
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515156}
[modify] https://crrev.com/b3e858120c7eb7615b8b0b7e5b60cc61fa00bc07/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm

Comment 11 by lod@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on iPhone X iOS 11.1 on build 63.0.3239.48 in Portrait mode.
https://drive.google.com/a/google.com/file/d/1vb9WRkjTIeKsHFi4LJkkipMAnC6CttIz/view?usp=sharing


In landscape mode it still exists . So going to file new bug for that. Thanks

Comment 13 by lod@chromium.org, Nov 16 2017

Labels: -M-63 M-64
To clarify, this fix landed after branch point so it is not in 63. I will change it for m64 (as it's a bit late for a pri3 bug to be merged to 63 at this point). Please let me know if you are still seeing issues in landscape or portrait at this point, I am not seeing any locally.

Comment 14 by lod@chromium.org, Nov 16 2017

Cc: lod@chromium.org justincohen@chromium.org
 Issue 785029  has been merged into this issue.
Verified on M64.0.3269.0 Canary. Its stillrepor'ed on iPhone 6+ iOS 11.2 in portrait mode and landscape mode.
https://drive.google.com/a/google.com/file/d/1Ff4eQo_sqjZb2eY8krVjKENCjsn7n7kw/view?usp=sharing
This bug is about obscuring the iPhone X home screen indicator, not the NTP bottom bar.  It's expected that the keyboard and it's accessory views will obscure UI when it slides up.  Just not system UI like the home screen indicator.

I think you are verifying the wrong thing...
Sorry for all the above comments. I verified this bug on a diff understanding .
After talking to @justincohen, below is the correct verification: 

https://drive.google.com/a/google.com/file/d/1sNC-EdSCwVU_1ZNV_VJzqN560CTVzfJb/view?usp=sharing
Verified on iPhone X iOS 11.1 in M64.0.3269.0 Canary both in portrait and landscape mode.
The iPhone X home screen indicator is no longer obscured by the keyboard accessory.

Comment 18 by lod@chromium.org, Nov 17 2017

Thanks vbhatsoori & justin for getting this cleared up :)

Sign in to add a comment