New issue
Advanced search Search tips

Issue 764855 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Duplicate structure in render_widget_host_view_mac_editcommand_helper.mm

Project Member Reported by erikc...@chromium.org, Sep 13 2017

Issue description

https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.mm?sq=package:chromium

Each RenderWidgetHostViewMacEditCommandHelper creates a base::hash_set edit_command_set_. This hash_set contains ~90 strings. Its exactly the same for each RenderWidgetHostViewMacEditCommandHelper, and each WebContentsView creates a RenderWidgetHostViewMacEditCommandHelper. This wasted ~240KB of memory for my ~30 tab browser.

"""
RenderWidgetHostViewMacEditCommandHelper::
    RenderWidgetHostViewMacEditCommandHelper() {
  for (size_t i = 0; i < arraysize(kEditCommands); ++i) {
    edit_command_set_.insert(kEditCommands[i]);
  }
}
"""
 
Status: WontFix (was: Untriaged)
This regression has been open for half a year. It's not very actionable and the regression has been in all Chrome user's hands for months.

Sign in to add a comment