'git cl upload' failing |
||||||||||||||||||
Issue descriptionUpload to gerrit failing with "Created|Updated 0 issues on Gerrit, but only 1 expected." The Gerrit CL is created even though the command fails. After this error, the Gerrit CL is not associated with the local branch, so future uploads create a new Gerrit CL. 'git cl try' also does not work, saying, "git cl: error: Need to upload first". Full output from 'git cl upload': Running presubmit upload checks ... Presubmit checks took 8.6s to calculate. Presubmit checks passed. infra/bots/jobs.json | 10 --- infra/bots/tasks.json | 596 ++------------------------------------------------------------------------------------------------------------------------------------- 2 files changed, 8 insertions(+), 598 deletions(-) remote: Processing changes: new: 1, done remote: remote: New Changes: remote: https://skia-review.googlesource.com/#/c/skia/+/46306 Remove redundant jobs. remote: To https://skia.googlesource.com/skia * [new branch] d941689d5f897ab63577b5c35425bb01d11054f2 -> refs/for/refs/heads/master%wip,m=Initial_upload Error after CL description prompt -- saving description to /usr/local/google/home/benjaminwagner/.git_cl_description_backup Created|Updated 0 issues on Gerrit, but only 1 expected. Change-Id: I35a212f55b9f2cd1240f2f072321ee118a3feecc exit status: 1
,
Sep 13 2017
,
Sep 13 2017
,
Sep 13 2017
,
Sep 13 2017
I reproduced this in chromium repo as well: remote: Processing changes: new: 1, done remote: remote: New Changes: remote: https://chromium-review.googlesource.com/#/c/chromium/src/+/665662 Test remote: To https://chromium.googlesource.com/chromium/src.git * [new branch] b88f84919b30ab4e58fc7384033375be7fe13b6b -> refs/for/refs/heads/master%wip,m=Initial_upload Error after CL description prompt -- saving description to /usr/local/google/home/rmistry/.git_cl_description_backup Created|Updated 0 issues on Gerrit, but only 1 expected.
,
Sep 13 2017
Seeing the same thing trying to land VERSION bump changes in src.git, which is preventing cutting a new Chrome build. Raising priority.
,
Sep 13 2017
Yep, definitely an issue, and a change on the Gerrit side (since there aren't any git-cl or gerrit_util changes in depot_tools in the last few days). I just ran into it myself while uploading https://crrev.com/i/454272.
,
Sep 13 2017
,
Sep 13 2017
The remote now includes the project path in the "New Changes" block, so our output parsing is failing. Old: remote: New Changes: remote: https://chromium-review.googlesource.com/XXXX Description goes here New: remote: New Changes: remote: https://chromium-review.googlesource.com/#/c/chromium/src/+/XXXX Description goes here Fixing on the git-cl side.
,
Sep 13 2017
This is blocking M61 Stable RC cut for Desktop.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/289b43183e98bdec9e8bc45be1eb462876cccebc commit 289b43183e98bdec9e8bc45be1eb462876cccebc Author: Aaron Gable <agable@chromium.org> Date: Wed Sep 13 21:21:38 2017 git-cl: Parse new change urls containing project paths Bug: 764848 Change-Id: I639451ad54eb50a405fe44b9a83b00d84ec76578 Reviewed-on: https://chromium-review.googlesource.com/665998 Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/289b43183e98bdec9e8bc45be1eb462876cccebc/tests/git_cl_test.py [modify] https://crrev.com/289b43183e98bdec9e8bc45be1eb462876cccebc/git_cl.py
,
Sep 13 2017
Should be fixed now. Please verify.
,
Sep 13 2017
Oh no, catch-22. It looks like this problem has also been causing the recipe-roller to fail since: https://uberchromegw.corp.google.com/i/internal.infra.cron/builders/recipe-autoroller-internal/builds/69022 but I guess it can't roll itself to the fi (or something), so is still failing, and so anything using depot_tools in recipes is also still broken (like the release bots).
,
Sep 13 2017
Oh, but it still created the CLs - e.g. https://chromium-review.googlesource.com/c/infra/infra/+/665658 which I'm guessing we can just land manually? LMK if I can be of help here (trooper).
,
Sep 13 2017
Ah, good catch. I'll try to land them and see if that helps it get to the fix.
,
Sep 13 2017
wpt-import (yet another roller) is also currently broken by this issue: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer
,
Sep 13 2017
I'm clearly still missing something here. I committed the pending roll CLs, in a few different repos, and the recipe roller appears to be back to the state it was in before (failing the skia step, but that has been happening for a long time), but depot_tools is still stuck at a revision from earlier today, 3 or 4 commits before this fix. Is there something else that controls the depot_tool rolls?
,
Sep 13 2017
,
Sep 13 2017
reassigning to recipe roller owners
,
Sep 13 2017
The roll you committed (https://chromium-review.googlesource.com/c/infra/infra/+/665744) only updated the build pin, not the depot_tools pin. It needs a manual roll.
,
Sep 13 2017
Yeah, I knew it didn't update depot_tools, but I thought after that got in, then it would create another one to update depot_tools. Or is depot_tools always rolled manually (which might be the something I'm missing)?
,
Sep 13 2017
https://chromium-review.googlesource.com/c/chromium/tools/build/+/666081 not all changes to depot_tools (in particular, ones that don't touch recipes, like git-cl changes) don't trigger recipe rolls.
,
Sep 13 2017
Ah, yeah, that makes sense, thanks.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/2b71719f0909acdd6443f1ff90c8d8ad5a692dd7 commit 2b71719f0909acdd6443f1ff90c8d8ad5a692dd7 Author: Aaron Gable <agable@chromium.org> Date: Wed Sep 13 23:23:36 2017 Manually roll depot_tools recipes to pick up git-cl fix TBR=nodir@chromium.org Bug: 764848 Change-Id: Ifa5e50a935a88ed9d1c866270486ce8668827633 Reviewed-on: https://chromium-review.googlesource.com/666081 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> [modify] https://crrev.com/2b71719f0909acdd6443f1ff90c8d8ad5a692dd7/scripts/slave/README.recipes.md [modify] https://crrev.com/2b71719f0909acdd6443f1ff90c8d8ad5a692dd7/infra/config/recipes.cfg
,
Sep 13 2017
Manual roll landed; should result in cascading rolls into infra and other repos now.
,
Sep 13 2017
Kicked this roll (https://chromium-review.googlesource.com/c/infra/infra/+/665838) and hopefully things will improve.
,
Sep 13 2017
Recipe roller has started successfully uploading and landing its own changes in further downstream repos. This indicates that the roll into infra was sufficient to fix the issue for recipe roller, and should fix it for other bots as well. Please verify.
,
Sep 14 2017
Release bots look happy now. Thanks!
,
Sep 14 2017
,
Sep 14 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Sep 14 2017
,
Sep 14 2017
Issue 765035 has been merged into this issue.
,
Sep 14 2017
,
Sep 14 2017
,
Sep 14 2017
Issue 765325 has been merged into this issue.
,
Sep 15 2017
Issue 765259 has been merged into this issue.
,
Sep 15 2017
,
Sep 19 2017
FYI -- if you're still hitting upload failures, run "gclient" with no other args to pick up the fix, which is in git-cl itself. Afterwards you'll need to re-upload any failing patch sets.
,
Oct 5 2017
Issue gerrit:7352 has been merged into this issue.
,
Oct 9 2017
,
Oct 21 2017
Issue 766202 has been merged into this issue.
,
Jan 3 2018
Issue 765423 has been merged into this issue. |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by benjamin...@google.com
, Sep 13 2017