Add Testing for Trigger Alternate Nav Infobar (a.k.a. did-you-mean bar) |
||
Issue descriptionThere are no unit tests for the causes of triggering this in ChromeOmniboxNavigationObserver.
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d337597b5491fe5eeb6308703bcde9a5af8e6c94 commit d337597b5491fe5eeb6308703bcde9a5af8e6c94 Author: Mark Pearson <mpearson@chromium.org> Date: Tue Sep 19 23:36:05 2017 Omnibox - Add Testing for Trigger Alternate Nav Infobar & Fix Bug Adds tests for triggering of the alternate nav infobar (a.k.a. the did-you-mean bar). In the process, I found and fixed a bug I recently introduced in patch https://chromium-review.googlesource.com/c/chromium/src/+/664921 This bug was that all redirect that did not qualify as OnlyChangeIsFromHTTPToHTTPS() were treated as failures, i.e., we didn't show the infobar in those cases. We should have. This change fixes the bug and adds tests. Yay for testing! Bug: 764843 Change-Id: I854a71b51da516ef4ff18bbbfc10847ec8733826 Reviewed-on: https://chromium-review.googlesource.com/671648 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#502989} [modify] https://crrev.com/d337597b5491fe5eeb6308703bcde9a5af8e6c94/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc [modify] https://crrev.com/d337597b5491fe5eeb6308703bcde9a5af8e6c94/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h [modify] https://crrev.com/d337597b5491fe5eeb6308703bcde9a5af8e6c94/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer_unittest.cc
,
Sep 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mpear...@chromium.org
, Sep 13 2017