New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764822 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Restart mysql_stats when MySQL restarts

Project Member Reported by pho...@chromium.org, Sep 13 2017

Issue description

mysql_stats.py is not outputting any data.
 

Comment 1 by pho...@chromium.org, Sep 13 2017

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e587fd67bd5daccfc55474ddbeb3a25fa45ff066

commit e587fd67bd5daccfc55474ddbeb3a25fa45ff066
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Sep 14 02:28:26 2017

[autotest] Fix use of RetryingConnection

The .Execute method returns the number of rows found, not the results of
Fetchall().

BUG= chromium:764822 
TEST=Tested locally

Change-Id: Ie0559245c2908c0c578bf9c67cde8f56486920e7
Reviewed-on: https://chromium-review.googlesource.com/665324
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/e587fd67bd5daccfc55474ddbeb3a25fa45ff066/site_utils/stats/mysql_stats_unittest.py
[modify] https://crrev.com/e587fd67bd5daccfc55474ddbeb3a25fa45ff066/site_utils/stats/mysql_stats.py

Comment 3 by pho...@chromium.org, Sep 15 2017

Summary: Restart mysql_stats when MySQL restarts (was: MySQL stats is down)
fixed temporarily by restarting it.

The permanent fix would be to make sure mysql_stats resets its metrics when the mysql service restarts.

Comment 4 by pho...@chromium.org, Dec 18 2017

Status: Archived (was: Started)

Comment 5 by pho...@chromium.org, Dec 19 2017

Status: Assigned (was: Archived)
My solution to this was to change the mysql_stats upstart job
to restart with the mysql job.

I have that change now.  Is there an alternative fix that has
some superior characteristic?

Comment 7 by pho...@chromium.org, Dec 19 2017

Owner: jrbarnette@chromium.org
No, that's perfect, thanks.

My plan to make the mysql_stats script catch the Exception that is thrown when the input to a Counter decreases, and manually .reset the metric, but this works too.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/fedaa4da1a68d5b8a32382ba36d615211d962c2f

commit fedaa4da1a68d5b8a32382ba36d615211d962c2f
Author: Richard Barnette <jrbarnette@google.com>
Date: Tue Dec 19 03:01:39 2017

Status: Verified (was: Assigned)
For reasons unrelated to this change, I just restarted mysqld
on the master server.  And, Lo! the mysql_stats job restarted.

Sign in to add a comment