New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764816 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 589943



Sign in to add a comment

Non-visible Downloads Bar buttons are shown to screen reader (VoiceOver)

Project Member Reported by barryaustin@google.com, Sep 13 2017

Issue description

Chrome Version       : 60.0.3112.101
OS Version: OS X 10.12.6
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 55.0.2: OK
     IE 7/8/9:

What steps will reproduce the problem?
1. With VoiceOver enabled (Command-F5), browse to any page, e.g. https://www.google.com.
2. Using shift-tab, navigate off the web content; e.g. a bookmarks bar item is in focus.
3. Using the VoiceOver modifier key + right arrow, navigate to web content; VoiceOver reads e.g. "Google web content".
4. Using the VoiceOver modifier key + right arrow, navigate one step further.

What is the expected result?
VoiceOver screen reader does not read Downloads Bar buttons because they are visually hidden (as is the entire Downloads Bar).

What happens instead of that?
VoiceOver reads "show all button", and next is "close button", with no context about a Downloads Bar. The VoiceOver cursor is not in the visible area, nor are the buttons visible. Selecting the show all button (pressing space) causes a new tab to open with Chrome's download history (chrome://downloads).

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36
 
Labels: Needs-Triage-M60
Cc: lgrey@chromium.org sdy@chromium.org ellyjo...@chromium.org
Components: UI>Accessibility
Status: Available (was: Unconfirmed)
Labels: Hotlist-CocoaBrowser

Comment 4 by sdy@chromium.org, Sep 13 2017

Cc: -sdy@chromium.org -lgrey@chromium.org -ellyjo...@chromium.org
Components: UI>Browser>Downloads
Labels: -Pri-3 -Needs-Triage-M60 M-63 Pri-2
Owner: sdy@chromium.org
Status: Assigned (was: Available)
I'm aware of this and it's an old issue. I've been meaning to fix it as part of the MD downloads effort, though.

Comment 5 by sdy@chromium.org, Oct 6 2017

Blocking: 589943

Comment 6 by sdy@chromium.org, Oct 6 2017

Labels: -M-63 M-64
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0dd21ed7734e79b56e732592e78b1c7ea9246f7

commit e0dd21ed7734e79b56e732592e78b1c7ea9246f7
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Oct 17 21:51:17 2017

Fix download shelf not being set hidden and VoiceOver not noticing that it's hidden.

Bug:  764816 
Change-Id: If4737e1f144dab5134d91623ec5dc60fc98270b5
Reviewed-on: https://chromium-review.googlesource.com/723900
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509553}
[modify] https://crrev.com/e0dd21ed7734e79b56e732592e78b1c7ea9246f7/chrome/browser/ui/cocoa/download/download_shelf_controller.mm

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on mac 10.12.6 using latest chrome version #64.0.3243.0 as per comment #0.
Observed that after step 3 i.e when the VoiceOver reads e.g. "Google web content" on pressing VoiceOver modifier key + right arrow and then again on pressing VoiceOver modifier key + right arrow, voiceOver screen reader did not read downloads bar buttons, rather it repeatedly read "Google web content".

Note: Observed the same behaviour using chrome reported version #60.0.3112.101 also.

Attached screencasts of both reported version #60.0.3112.101 and latest chrome version #64.0.3243.0 for reference.

sdy@ - Could you please let us know the expected behaviour and please confirm the fix.

Thanks...!!
764816@M64.mp4
1.3 MB View Download
764816@M60.mp4
1.5 MB View Download

Comment 9 by sdy@chromium.org, Oct 18 2017

Status: Fixed (was: Assigned)
krajshree@: Would you mind testing after entering/exiting full screen once? That should reproduce the issue.

Comment 10 by sdy@chromium.org, Dec 5 2017

Labels: allpublic

Sign in to add a comment