New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764815 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

wl_surface_frame callback is not called when we use BackToBackBeginFrameSource in perftests

Project Member Reported by penghuang@chromium.org, Sep 13 2017

Issue description

wl_surface_frame callback is not called when we use BackToBackBeginFrameSource in perftests
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70d144ce1f916439e83cf997daed5b896f494cce

commit 70d144ce1f916439e83cf997daed5b896f494cce
Author: Peng Huang <penghuang@google.com>
Date: Wed Sep 13 22:44:52 2017

Exo: make sure wl_surface_frame callback will be called.

In some case, the begin frame can arrive just before
DidReceivedCompositorFrameAck(), so the active_frame_callbacks_ is
empty, but the frame callback is still in frame_callbacks_. To make
sure frame callbacks will be called, we need receive more begine
frame. This CL fixes the issue by requesting more begin frames when
frame_callbacks_ is not empty.

Bug:  764815 
Change-Id: I9750b9c4bde6e84eba534bcc7f08c2d19bab9a21
Reviewed-on: https://chromium-review.googlesource.com/665543
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501776}
[modify] https://crrev.com/70d144ce1f916439e83cf997daed5b896f494cce/components/exo/surface_tree_host.cc

Status: Fixed (was: Started)

Sign in to add a comment