This is nice to have clean-up task. We're mixing use of OnceCallback and Callback. For one time callback, we should use OnceCallback, specifically for mojo call and D-Bus client call.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3 commit 3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Wed Oct 11 10:31:25 2017 Migrate GetArcStartTimeCallback into DBusMethodCallback. BUG=739622, 764795 TEST=Build. Change-Id: I11259eca4499b238448fc3d0aee568417250f4f4 Reviewed-on: https://chromium-review.googlesource.com/709294 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#507940} [modify] https://crrev.com/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3/chromeos/dbus/fake_session_manager_client.cc [modify] https://crrev.com/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3/chromeos/dbus/fake_session_manager_client.h [modify] https://crrev.com/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3/chromeos/dbus/session_manager_client.cc [modify] https://crrev.com/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3/chromeos/dbus/session_manager_client.h [modify] https://crrev.com/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3/components/arc/metrics/arc_metrics_service.cc [modify] https://crrev.com/3c446ed6ba1f60b6ca832a3fc09d12936e3a3db3/components/arc/metrics/arc_metrics_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/853a0da41015ac7e1a4b5ee5884d42e9adcd62e2 commit 853a0da41015ac7e1a4b5ee5884d42e9adcd62e2 Author: Hidehiko Abe <hidehiko@chromium.org> Date: Fri Oct 20 09:03:06 2017 Migrate StartArcInstanceCallback into OnceCallback. BUG=739622, 764795 TEST=Build. Change-Id: Ia16634f77fc49fb8fafdcf21b50636b06b8568a2 Reviewed-on: https://chromium-review.googlesource.com/730028 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510384} [modify] https://crrev.com/853a0da41015ac7e1a4b5ee5884d42e9adcd62e2/chromeos/dbus/fake_session_manager_client.cc [modify] https://crrev.com/853a0da41015ac7e1a4b5ee5884d42e9adcd62e2/chromeos/dbus/fake_session_manager_client.h [modify] https://crrev.com/853a0da41015ac7e1a4b5ee5884d42e9adcd62e2/chromeos/dbus/session_manager_client.cc [modify] https://crrev.com/853a0da41015ac7e1a4b5ee5884d42e9adcd62e2/chromeos/dbus/session_manager_client.h [modify] https://crrev.com/853a0da41015ac7e1a4b5ee5884d42e9adcd62e2/components/arc/arc_session.cc
Comment 1 by bugdroid1@chromium.org
, Oct 11 2017