New issue
Advanced search Search tips

Issue 764790 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 760181



Sign in to add a comment

ContentBrowserTests-Viz: layouttest_support

Project Member Reported by jonr...@chromium.org, Sep 13 2017

Issue description

layouttest_support has dependencies on:
  -  components/viz/common/quads/copy_output_request.h
  -  components/viz/test/test_layer_tree_frame_sink.h
  -  viz::ContextProvider
  -  viz::RendererSettings
  -  viz::LocalSurfaceId

Find out how the Viz process split impacts this test, and update.
 
Cc: jonr...@chromium.org
 Issue 764808  has been merged into this issue.
LayoutTestDependencies and LayoutTestDependenciesImpl are both contained or subclasses of this file.
CopyRequestSwapPromise is using TestLayerTreeFrameSink which is tied to viz/service.

These will need to be updated.
CopyRequestSwapPromise seems to end up being redirect to pixel_dump tests:

src/content/shell/test_runner/pixel_dump.cc

However content shell layout tests trigger this on each call to RenderThreadImpl::RequestNewLayerTreeFrameSink can lead to its creation. As they instantiate LayoutTestContentBrowserClient
From danakj@: Layout tests run the display compositor in the renderer (ie run viz services directly in the renderer)

So these will be fine for the initial viz process split.

Comment 6 by laforge@google.com, Nov 8 2017

Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.
Status: WontFix (was: Untriaged)
As noted with the layout tests running in renderer, these will not be affected by the viz split. So nothing else to do.

Sign in to add a comment