New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Record when a Camera search is triggered from the omnibox' assistive view.

Project Member Reported by jif@chromium.org, Sep 13 2017

Issue description

This metric is needed to make decision regarding the product's roadmap, hence it should be cherry-picked to M62.
 

Comment 1 by jif@chromium.org, Sep 13 2017

Labels: -Pri-3 Pri-2

Comment 2 by cma...@chromium.org, Sep 14 2017

Is this related to QR code scanner?

Comment 3 by jif@chromium.org, Sep 14 2017

Components: UI>Browser>Mobile>QRScanner

Comment 4 by jif@chromium.org, Sep 14 2017

Yes
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2199ed5089131580ec523bcb92a5f6e19d568d7a

commit 2199ed5089131580ec523bcb92a5f6e19d568d7a
Author: Jean-François Geyelin <jif@chromium.org>
Date: Thu Sep 14 15:32:04 2017

Add metrics for camera search on iOS.

Bug:  764748 
Change-Id: Id3429bb603b10db2899557192e24b9db31614ebc
Reviewed-on: https://chromium-review.googlesource.com/664816
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501957}
[modify] https://crrev.com/2199ed5089131580ec523bcb92a5f6e19d568d7a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/2199ed5089131580ec523bcb92a5f6e19d568d7a/tools/metrics/actions/actions.xml

Comment 6 by jif@chromium.org, Sep 18 2017

Labels: Merge-Request-62
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 18 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Less than 25 days to go before AppStore submit on M62
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by cma...@chromium.org, Sep 19 2017

Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Approved upon verification of the CL in Canary and on branch 3202
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 25 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 26 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca2c0a2d38e6cee48c9593dd94b66a540b95a30

commit dca2c0a2d38e6cee48c9593dd94b66a540b95a30
Author: Jean-François Geyelin <jif@chromium.org>
Date: Tue Sep 26 14:51:00 2017

Add metrics for camera search on iOS.

Bug:  764748 
Change-Id: Id3429bb603b10db2899557192e24b9db31614ebc
Reviewed-on: https://chromium-review.googlesource.com/664816
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501957}(cherry picked from commit 2199ed5089131580ec523bcb92a5f6e19d568d7a)
Reviewed-on: https://chromium-review.googlesource.com/684179
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#448}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/dca2c0a2d38e6cee48c9593dd94b66a540b95a30/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/dca2c0a2d38e6cee48c9593dd94b66a540b95a30/tools/metrics/actions/actions.xml

Sign in to add a comment