Some design choices made during the implementation of ContentSuggestions are no longer relevant and should be cleaned up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef394f3aae97b4735472e11fd89e3403ed68b1c7 commit ef394f3aae97b4735472e11fd89e3403ed68b1c7 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 14 09:15:29 2017 Move responsabilities from Coordinator to Mediator The ContentSuggestionsCoordinator is doing too many things. Some of its reponsabilities can be moved to a mediator, to allow better atomicity of responsabilities and have this code reusable. Bug: 764720 Change-Id: I40e9f65f8b024498331dab855e6503c0c9090825 Reviewed-on: https://chromium-review.googlesource.com/665120 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501909} [modify] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [add] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/ntp_home_mediator.h [add] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/ntp_home_mediator.mm [modify] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/ntp_home_metrics.h [modify] https://crrev.com/ef394f3aae97b4735472e11fd89e3403ed68b1c7/ios/chrome/browser/content_suggestions/ntp_home_metrics.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5db75eceaaeb9f77c888aed84c419d6b311d4a9a commit 5db75eceaaeb9f77c888aed84c419d6b311d4a9a Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 14 13:39:15 2017 [ios clean] NTP Coordinator uses mediator Use the mediator in the coordinator to avoid code duplication. Bug: 764720 , 753391 Change-Id: Ib56cda9e0267e5dc98f7f51fdc3ee2185a245228 Reviewed-on: https://chromium-review.googlesource.com/665237 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501942} [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/chrome/browser/content_suggestions/ntp_home_mediator.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller_delegate.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h [modify] https://crrev.com/5db75eceaaeb9f77c888aed84c419d6b311d4a9a/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ce6ba7315d0db69f16536cacfcbdf631bb15e03 commit 8ce6ba7315d0db69f16536cacfcbdf631bb15e03 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Nov 09 18:31:20 2017 Prepare tests to run with ContentSuggestions This tests is making sure the tests are able to run with ContentSuggestions enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia7ea99614f6020841273733ae4ea126e3d84155a Reviewed-on: https://chromium-review.googlesource.com/758648 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515216} [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/8ce6ba7315d0db69f16536cacfcbdf631bb15e03/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11bc1f22a806c84671939139d6ab108618cdda24 commit 11bc1f22a806c84671939139d6ab108618cdda24 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 10 10:11:38 2017 Prepare AppState test for ContentSuggestions This CL makes sure that the AppState unit tests can run with ContentSuggestions enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0773b29330f1a0b139b0f25a707e9d58c1f87cd8 Reviewed-on: https://chromium-review.googlesource.com/758838 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515520} [modify] https://crrev.com/11bc1f22a806c84671939139d6ab108618cdda24/ios/chrome/app/application_delegate/BUILD.gn [modify] https://crrev.com/11bc1f22a806c84671939139d6ab108618cdda24/ios/chrome/app/application_delegate/app_state_unittest.mm [modify] https://crrev.com/11bc1f22a806c84671939139d6ab108618cdda24/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc [modify] https://crrev.com/11bc1f22a806c84671939139d6ab108618cdda24/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba60a74e31c909b70bd925416e3ba4c1b345113a commit ba60a74e31c909b70bd925416e3ba4c1b345113a Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 10 11:00:32 2017 Change the NTP header constraints for test This CL changes the constraints of the NTP header to allow them to work with a nil logoVendor. This happens during tests. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieba12be198bfdcb6cffc8640d5f0793b6059d966 Reviewed-on: https://chromium-review.googlesource.com/758839 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515526} [modify] https://crrev.com/ba60a74e31c909b70bd925416e3ba4c1b345113a/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/ba60a74e31c909b70bd925416e3ba4c1b345113a/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [modify] https://crrev.com/ba60a74e31c909b70bd925416e3ba4c1b345113a/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e574541330fd968a857d8f5f38f32df1486fb420 commit e574541330fd968a857d8f5f38f32df1486fb420 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 17 11:02:04 2017 Enable ContentSuggestions by default This CL enables the ContentSuggestions flag by default. The rollout is currently being done using finch and will reach 100% soon. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I52ace8c4240275abf75b1e8b16433cbccbc78d15 Reviewed-on: https://chromium-review.googlesource.com/754840 Reviewed-by: Menglu Huang <huangml@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517369} [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/app/tests_fake_hook.mm [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/app/tests_hook.h [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/browser/ntp_snippets/BUILD.gn [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/e574541330fd968a857d8f5f38f32df1486fb420/ios/chrome/test/earl_grey/eg_tests_hook.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b984fc2164a9f78b1210e9b4596adc3632c40ea commit 6b984fc2164a9f78b1210e9b4596adc3632c40ea Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 17 17:22:02 2017 Favicon for TileSaver are downloaded in ContentSuggestions ContentSuggestions is enabled to 100%, the GoogleLandingMediator won't be used anymore. Saving the favicons for the Content widget should be done from the ContentSuggestionsMediator. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31667a896cfdbe378d0efa6b67df5c8e9189d4d7 Reviewed-on: https://chromium-review.googlesource.com/776798 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517447} [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.h [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/content_suggestions/content_suggestions_favicon_mediator.mm [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/ui/ntp/ntp_tile_saver.h [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/ui/ntp/ntp_tile_saver.mm [modify] https://crrev.com/6b984fc2164a9f78b1210e9b4596adc3632c40ea/ios/chrome/browser/ui/ntp/ntp_tile_saver_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105f4e38d7ae6d2868d1e0375c2d33b7989f9783 commit 105f4e38d7ae6d2868d1e0375c2d33b7989f9783 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Nov 17 17:35:48 2017 Remove old NTP code This code is no longer used as ContentSuggestions is enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1cf12abd965840c1f02c137fa4f542057842648d Reviewed-on: https://chromium-review.googlesource.com/776653 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517452} [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/app/application_delegate/app_state_unittest.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/app/startup/content_suggestions_scheduler_notifications.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/chrome_switches.cc [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/chrome_switches.h [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/experimental_flags.h [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/resources/Settings.bundle/Experimental.plist [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/ntp/BUILD.gn [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/google_landing_view_controller.h [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/google_landing_view_controller.mm [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/google_landing_view_controller_unittest.mm [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/most_visited_cell.h [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/most_visited_cell.mm [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/most_visited_cell_unittest.mm [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/most_visited_layout.h [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/most_visited_layout.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/ntp/new_tab_page_bar.h [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/whats_new_header_view.h [delete] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/ios/chrome/browser/ui/ntp/whats_new_header_view.mm [modify] https://crrev.com/105f4e38d7ae6d2868d1e0375c2d33b7989f9783/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45fce0dc3366eeccc5ee5310089b72d2f189b79c commit 45fce0dc3366eeccc5ee5310089b72d2f189b79c Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Nov 20 12:51:35 2017 Clean up GoogleLandingConsumer/DataSource ContentSuggestions is enabled to 100%, those methods can be removed as they were only used in the old NTP. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7606b7635862168e9e019ad8bb8175b9d11484b1 Reviewed-on: https://chromium-review.googlesource.com/778860 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517806} [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/app/spotlight/BUILD.gn [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/app/spotlight/topsites_spotlight_manager.mm [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/ui/ntp/google_landing_consumer.h [delete] https://crrev.com/0855a8dbdf1941d35b0bea0551ed3653e79d96b2/ios/chrome/browser/ui/ntp/google_landing_data_source.h [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/ui/ntp/google_landing_mediator.h [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm [modify] https://crrev.com/45fce0dc3366eeccc5ee5310089b72d2f189b79c/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d commit 7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Nov 28 09:08:32 2017 Add SearchEngineObserver This CL adds a SearchEngineObserver as a standalone class, instead of having it duplicated in two files. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iea5d4628e75ea4ae1e7afc349cfb958292f6a38d Reviewed-on: https://chromium-review.googlesource.com/790990 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#519620} [modify] https://crrev.com/7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d/ios/chrome/browser/search_engines/BUILD.gn [add] https://crrev.com/7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d/ios/chrome/browser/search_engines/search_engine_observer_bridge.h [add] https://crrev.com/7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d/ios/chrome/browser/search_engines/search_engine_observer_bridge.mm [modify] https://crrev.com/7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/7e0ee87b0bbe0aff4a62b4e4ffaa201c83cb9e0d/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ca65b4bcf97b0f54d510651af927c6b0ef983db commit 0ca65b4bcf97b0f54d510651af927c6b0ef983db Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Dec 05 08:49:29 2017 Merge GoogleLandingMediator into NTPHomeMediator This CL removes GoogleLandingMediator/Consumer and moves their functionalities in NTPHomeMediator/Consumer. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iae7ca5707afd04933c189391a50e384940303eb2 Reviewed-on: https://chromium-review.googlesource.com/801012 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521642} [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/ntp_home_mediator.h [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/ntp_home_mediator.mm [add] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/content_suggestions/ntp_home_mediator_unittest.mm [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/ui/content_suggestions/BUILD.gn [add] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/ui/content_suggestions/ntp_home_consumer.h [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/ui/ntp/BUILD.gn [delete] https://crrev.com/6ed69ac878454fe3606b867eb4a15145baed701c/ios/chrome/browser/ui/ntp/google_landing_consumer.h [delete] https://crrev.com/6ed69ac878454fe3606b867eb4a15145baed701c/ios/chrome/browser/ui/ntp/google_landing_mediator.h [delete] https://crrev.com/6ed69ac878454fe3606b867eb4a15145baed701c/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/0ca65b4bcf97b0f54d510651af927c6b0ef983db/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd80d3c44398d535ad343d9d08f1413acf7e2cf7 commit bd80d3c44398d535ad343d9d08f1413acf7e2cf7 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 11 17:06:44 2017 Change ContentSuggestions target to UI The ContentSuggestions UI target should have been named content_suggestions_ui. The content_suggestion target is the one for the coordinator layer. For now the coordinator/mediator are living in the ios/chrome/browser folder. They will be moved in a future CL. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3d2444a4b4caa7897886f69c65774a1b07c8eaa0 Reviewed-on: https://chromium-review.googlesource.com/813755 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523115} [modify] https://crrev.com/bd80d3c44398d535ad343d9d08f1413acf7e2cf7/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/bd80d3c44398d535ad343d9d08f1413acf7e2cf7/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/bd80d3c44398d535ad343d9d08f1413acf7e2cf7/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/bd80d3c44398d535ad343d9d08f1413acf7e2cf7/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/bd80d3c44398d535ad343d9d08f1413acf7e2cf7/ios/showcase/content_suggestions/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dff98f07376e9b21087bdd3c21aaf8da477d335 commit 6dff98f07376e9b21087bdd3c21aaf8da477d335 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Dec 20 17:08:37 2017 Move ContentSuggestions coordinator layer to ui/ The ContentSuggestions coordinator layer was incorrectly created in ios/chrome/browser/content_suggestions instead of in ios/chrome/browser/ui/content_suggestions. This CL fixes it by moving all the files to the correct location. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifd3518f668f07726af0b8a320ea337de182099e2 Reviewed-on: https://chromium-review.googlesource.com/836392 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#525353} [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/app/spotlight/BUILD.gn [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/app/spotlight/topsites_spotlight_manager.mm [delete] https://crrev.com/19e1245c649cb5ad35ec3d80c08e9d00c94514cf/ios/chrome/browser/content_suggestions/BUILD.gn [delete] https://crrev.com/19e1245c649cb5ad35ec3d80c08e9d00c94514cf/ios/chrome/browser/content_suggestions/OWNERS [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/BUILD.gn [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_alert_factory.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_alert_factory.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_category_wrapper.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_category_wrapper.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_category_wrapper_unittest.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_mediator.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_mediator.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recorder.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recorder.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_service_bridge_observer.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/content_suggestions_service_bridge_observer.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/mediator_util.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/mediator_util.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator_unittest.mm [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/ntp_home_metrics.h [rename] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/content_suggestions/ntp_home_metrics.mm [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/6dff98f07376e9b21087bdd3c21aaf8da477d335/ios/chrome/test/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Sep 14 2017