New issue
Advanced search Search tips

Issue 764703 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

remote trybots: add support for chromium browser changes (in the new gerrit world)

Project Member Reported by mnissler@chromium.org, Sep 13 2017

Issue description

I kicked off a remote trybot against a release branch, passing a chromium gerrit CL: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/14800

This includes a couple chromium changes, for example: https://chromium-review.googlesource.com/c/chromium/src/+/664884

The PatchChanges step fails with the following error:

06:22:22: ERROR: Failed applying patches: CL:664884 could not be found in the repo manifest
 

Comment 1 by vapier@chromium.org, Sep 13 2017

Summary: remote trybots: add support for chromium browser changes (in the new gerrit world) (was: Remote trybots don't know how to handle a gerrit chromium CL)
hmm, we'll have to revert part of https://chromium-review.googlesource.com/612822 and update/rework the code to handle this.  if we want to keep the -g option, we'll need to dynamically differentiate between browser & non-browser repos.  but then we wouldn't be able to easily differentiate patches for repos that the two projects share (like chromite itself).  so i think the only sane option would be to add a new option for users to explicitly say "apply this patch to the browser".

Comment 2 Deleted

Comment 3 Deleted

Sign in to add a comment